Repository navigation
Conversation
Contributor
Author
|
The failed Python 3.10 wheel job completed the build and auditwheel repair, then timed out during cibuildwheel's Docker cleanup. I did not find a build failure related to this change. Could someone with rerun access retry that job? My fork account cannot rerun upstream Actions. Thanks! |
…rence-benchmark-timeout
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39949 +/- ##
============================================
+ Coverage 56.16% 56.19% +0.02%
Complexity 2288 2288
============================================
Files 1124 1124
Lines 178336 178343 +7
Branches 1489 1489
============================================
+ Hits 100170 100220 +50
+ Misses 75645 75602 -43
Partials 2521 2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bvolpato
force-pushed
the
bvolpato/fix-inference-benchmark-timeout
branch
2 times, most recently
from
October 8, 2026 23:54
36dc3f2 to
671336d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the timeout-related part of #38782.
The object-detection example cancels its Dataflow job after a hard-coded 30-minute wait, while the benchmark workflow allows 180 minutes per step. This change adds
--timeout_ms, keeps the 30-minute default, and sets the shared CPU/GPU batch/streaming benchmark options to 60 minutes.This PR remains draft until a healthy run shows that 30 minutes is too short. The fixed-batch change in #39953 is upstream and may affect runtime. The recorded failure has repeated SDK harness disconnections before cancellation, so it does not establish healthy runtime. A later run failed during setup and skipped the benchmarks.
Python checks pass; end-to-end timing still needs the Dataflow benchmark infrastructure. Run the local Python unit suite with:
addresses #123orfixes #456).CHANGES.mdwith noteworthy changes.See CONTRIBUTING.md for contribution guidelines.