Repository navigation
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Please refrain from using automated Agent sending untested PRs. This would squeeze reviewer resources |
httpclient5 5.4.3→5.5 upgrade (transitive dependency) breaks OAUTHBEARER auth against GCP Managed Service for Apache Kafka. The google-auth-library- oauth2-http relies on httpclient5 for HTTP transport, and the 5.5 upgrade is incompatible with the existing auth library version. Fixes apache#39789
Member
|
I'm unclear whether this is a good fix, and if it is an OK fix if it should be in BeamModulePlugin rather than the expansion service build file. In any event, this PR needs an integration test that fails before the change and passes after. |
Contributor
|
#40311 is proper fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39789
The httpclient5 5.4.3→5.5 upgrade broke OAUTHBEARER auth against GCP Managed Service for Apache Kafka. The google-auth-library-oauth2-http (1.37.1) is compiled against httpclient5 5.4.x and the 5.5 upgrade introduces binary incompatibility at runtime.
This pins httpclient5 (and its transitive httpcore5) to the versions that were in use at Beam 2.68.0, which was the last known-good release.
See #39789 for full bisection details.