Repository navigation
Eliminate nullability errors from :sdks:java:core #20507
Description
Just choose any file that starts with @SuppressWarnings("nullness") and eliminate the annotation and fix the errors!
As of 2020-07-20 setting -Xmaxerrs 10000 there are 1451 errors in the core Java SDK.
Imported from Jira BEAM-10496. Original Jira may contain additional context.
Reported by: kenn.
Subtask of issue #20497
Activity
aditya-mistri commentedon Feb 10, 2023
please assign me this issue , I want to work on this issue
damccorm commentedon Feb 10, 2023
Hey @aditya-mistri you can self assign issues by commenting
.take-issue. That will trigger a github action to assign you. It may take a little bit depending on load on actionsHoussemNasri commentedon Feb 18, 2023
As Aditya didn't respond to taking the issue, I assume he is no longer interested.
HoussemNasri commentedon Feb 18, 2023
.take-issue
HoussemNasri commentedon Feb 19, 2023
Hey @damccorm, I built the project locally and everything seems to go fine, but I'm not sure where to put the
enableChecker: true. As far as I understand, enableChecker should be passed to the beam gradle plugin. I have tried to pass it inside applyJavaNature closure but then loading gradle changes would fail. I also have tried to use enableSpotbugs instead, this time gradle reloads fine but compiling java files doesn't trigger the check to run.I did more research and stamped upon this PR #13134 which seems to enable the checker framework for all modules/classes and disable it for certain classes that match a certain pattern. I figured since the Jira ticket was opened before the PR then the issue might need an update.
damccorm commentedon Feb 21, 2023
@kennknowles do you have context here?
kennknowles commentedon Feb 21, 2023
Ah, the description is obsolete. Checker framework is enabled in all modules now. We automatically added
@SuppressWarnings("nullness")to every class that had nullness errors. To work on this issue, find a class that has@SuppressWarnings("nullness")and remove that, then fix the errors.kennknowles commentedon Feb 21, 2023
Since checkerframework is integrated into compilation, all you have to do to get the errors is recompile.
nitinware commentedon Sep 7, 2026
.take-issue
Remove nullness suppression in TimestampCombiner
Remove nullness suppression in TaggedPValue
nitinware commentedon Sep 16, 2026
this issue can be closed, fix addressed in pr: #40046
kennknowles commentedon Sep 16, 2026
I think there yet more suppressions to be eliminated. Thanks for what you've contributed so far, though!
nitinware commentedon Sep 17, 2026
Thanks @kennknowles, If you’re referring to #20497, I’ll take a look at the remaining nullness suppressions and work on addressing them.
Remove nullness suppression in PTransformReplacements
HoussemNasri commentedon Sep 19, 2026
.free-issue