Eliminate nullability errors from :sdks:java:extensions:sorter #20504

Activity

1. damccorm

   added

   clarified

   extensions-java-sorter

   good first issue

   P3

   sub-task

   on Jun 4, 2022
2. damccorm

   added

   extensions

   java

   sorter

   and removed

   extensions-java-sorter

   clarified

   on Jun 16, 2022
3. aditya-mistri commented on Feb 10, 2023

   

   aditya-mistri

   on Feb 10, 2023

   More actions

   Please assign me this issue , I want to work on this.
4. kennknowles

   assigned

   aditya-mistri

   on Apr 26, 2023
5. kennknowles commented on Apr 26, 2023

   

   kennknowles

   on Apr 26, 2023

   Member

   More actions

   Sorry for the delay @aditya-mistri. Do you still want to work on this? You can also use the .take-issue command in the future to take an issue.
6. nitinware commented on Sep 17, 2026

   

   nitinware

   on Sep 17, 2026

   Contributor

   More actions

   .take-issue
7. github-actions

   assigned

   nitinware

   on Sep 17, 2026
8. nitinware commented on Sep 27, 2026

   

   nitinware

   on Sep 27, 2026

   Last edited by nitinware

   Contributor

   More actions

   @damccorm @kennknowles -

   The sorter module already passes the nullness checker with no suppressions.

   The NullnessChecker is enabled by default for applyJavaNature modules (BeamModulePlugin.groovy), and the module has no nullness @SuppressWarnings.

   Verification

   ./gradlew :sdks:java:extensions:sorter:compileJava --rerun-tasks
   # BUILD SUCCESSFUL
   
   grep -rn 'SuppressWarnings("nullness")' sdks/java/extensions/sorter/src/main
   # no matches

   Since the module is already nullness-clean, this looks resolved and no code change is needed. Is this OK to close, or is there a suppression elsewhere you'd still like removed?
9. kennknowles commented on Sep 29, 2026

   

   kennknowles

   on Sep 29, 2026

   Member

   More actions

   Yup, we can close this!

   BUT: the search you really need is a multiline regex search with something like @SuppressWarnings\([^)]*"nullness (this is an overapproximation with some pitfalls, but probably close enough)

   👍React with 👍1Reacted by Nitin Ware
10. kennknowles

    closed this as completedon Sep 29, 2026
11. github-actions

    added this to the 2.78.0 Release milestone on Sep 29, 2026
12. nitinware commented on Sep 29, 2026

    

    nitinware

    on Sep 29, 2026

    Contributor

    More actions

    Thanks @kennknowles! Good point. I rechecked using the multiline regex as suggested and confirmed there are no nullness suppressions in the sorter module.