[AURON #2189] Periodically publish native metrics for long-running Fl… - #2494
Open
qingfei1994 wants to merge 2 commits into
Open
[AURON #2189] Periodically publish native metrics for long-running Fl…#2494qingfei1994 wants to merge 2 commits into
qingfei1994 wants to merge 2 commits into
Conversation
…ing Flink tasks
Contributor
|
hi @richox could you please help review this PR when you get a chance? Thanks! |
Contributor
|
Thanks for implementing scheduled metric reporting in Auron. Since this feature is currently only needed for Flink and not for Spark, I suggest adding a configuration item (e.g., Could you update the PR accordingly? |
…able metrics update for flink
Author
|
@richox I use a new configuration "auron.metrics.update.enabled", which is disabled by default and only when "flink.auron.metrics.update.enabled" = true and "flink.auron.metrics.update.interval.ms">0 will triggering the report metrics feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ink tasks
Which issue does this PR close?
Closes #2189
Rationale for this change
Native DataFusion metrics were only published to
MetricNodewhen the native runtime finalized. Spark batch tasks hit that path; long-running Flink tasks (Kafka source) do not, so Flink counters never moved after #2186 wiredaddto Flink.What changes are included in this PR?
MetricNode.adddoes not double-count.auron.metrics.update.interval.ms(default 1000; 0 = finalize-only).FlinkMetricNode.fromPlanso Kafka (including fusedProject[Filter[KafkaScan]]) and Calc share a plan-shaped metric tree forgetChild(i).Are there any user-facing changes?
Operators can set auron.metrics.update.interval.ms (default 1000ms). Spark SQL metrics may update during the job as a side effect of the same ticker.
How was this patch tested?
cargo test -p auron metricsFlinkMetricNodeFromPlanTest,AuronKafkaSourceFunctionMergeTest,FlinkMetricNodeTest,AuronAdaptorTestWas this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: Cursor Grok 4.6ASF guidance: https://www.apache.org/legal/generative-tooling.html