Skip to content

ATLAS-4766: java.lang.IllegalStateException from JanuGraph while purg… #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitalicod merged 1 commit into from
Jul 9, 2026
+383 −10
Merged

ATLAS-4766: java.lang.IllegalStateException from JanuGraph while purg… #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 68 additions & 10 deletions repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,21 @@ public Set<AtlasVertex> accumulateDeletionCandidates(Collection<AtlasVertex> ins
*/
public void deleteTraitsAndVertices(Collection<AtlasVertex> deletionCandidateVertices) throws AtlasBaseException {
for (AtlasVertex deletionCandidateVertex : deletionCandidateVertices) {
deleteAllClassifications(deletionCandidateVertex);
deleteTypeVertex(deletionCandidateVertex, isInternalType(deletionCandidateVertex));
if (deletionCandidateVertex == null) {
continue;
}

if (!deletionCandidateVertex.exists()) {
LOG.warn("deleteTraitsAndVertices(): skipping vertex - already removed");
continue;
}

try {
deleteAllClassifications(deletionCandidateVertex);
deleteTypeVertex(deletionCandidateVertex, isInternalType(deletionCandidateVertex));
} catch (IllegalStateException e) {
LOG.warn("deleteTraitsAndVertices(): skipping vertex - already removed", e);
}
}
}

Expand Down Expand Up @@ -717,11 +730,15 @@ public boolean isRelationshipEdge(AtlasEdge edge) {
boolean ret = false;

if (edge != null) {
String outVertexType = getTypeName(edge.getOutVertex());
String inVertexType = getTypeName(edge.getInVertex());
try {
String outVertexType = getTypeName(edge.getOutVertex());
String inVertexType = getTypeName(edge.getInVertex());

ret = GraphHelper.isRelationshipEdge(edge) || edge.getPropertyKeys().contains(RELATIONSHIP_GUID_PROPERTY_KEY) ||
(typeRegistry.getEntityTypeByName(outVertexType) != null && typeRegistry.getEntityTypeByName(inVertexType) != null);
ret = GraphHelper.isRelationshipEdge(edge) || edge.getPropertyKeys().contains(RELATIONSHIP_GUID_PROPERTY_KEY) ||
(typeRegistry.getEntityTypeByName(outVertexType) != null && typeRegistry.getEntityTypeByName(inVertexType) != null);
} catch (IllegalStateException e) {
LOG.warn("Skipping edge {} because one of its vertices was removed", edge.getIdForDisplay(), e);
}
}

return ret;
Expand Down Expand Up @@ -1255,17 +1272,45 @@ protected void deleteVertex(AtlasVertex instanceVertex, boolean force) throws At
final boolean isPurgeRequested = RequestContext.get().isPurgeRequested();

for (AtlasEdge edge : incomingEdges) {
if (!edge.exists()) {
LOG.debug("deleteVertex(): skipping edge {} - already removed in this transaction", edge.getIdForDisplay());
continue;
}

AtlasVertex outVertex;
try {
outVertex = edge.getOutVertex();
} catch (IllegalStateException e) {
LOG.warn("deleteVertex(): skipping edge {} - out-vertex was already removed", edge.getIdForDisplay(), e);
continue;
}

if (!outVertex.exists()) {
LOG.debug("deleteVertex(): skipping edge {} - out-vertex {} already removed in this transaction", edge.getIdForDisplay(), outVertex.getIdForDisplay());
continue;
}

AtlasEntity.Status edgeStatus = getStatus(edge);
boolean isProceed = edgeStatus == (isPurgeRequested ? DELETED : ACTIVE);

if (isProceed) {
if (isRelationshipEdge(edge)) {
deleteRelationship(edge);
} else {
AtlasVertex outVertex = edge.getOutVertex();

if (!isDeletedEntity(outVertex)) {
AtlasVertex inVertex = edge.getInVertex();
AtlasVertex inVertex;
try {
inVertex = edge.getInVertex();
} catch (IllegalStateException e) {
LOG.warn("deleteVertex(): skipping edge {} - in-vertex was already removed", edge.getIdForDisplay(), e);
continue;
}

if (!inVertex.exists()) {
LOG.debug("deleteVertex(): skipping edge {} - in-vertex {} already removed in this transaction", edge.getIdForDisplay(), inVertex.getIdForDisplay());
continue;
}

AtlasAttribute attribute = getAttributeForEdge(edge.getLabel());

deleteEdgeBetweenVertices(outVertex, inVertex, attribute);
Expand Down Expand Up @@ -1347,7 +1392,20 @@ private String getDelimitedPropagatedClassificationNames(AtlasVertex entityVerte
* @throws AtlasBaseException
*/
private void deleteAllClassifications(AtlasVertex instanceVertex) throws AtlasBaseException {
List<AtlasEdge> classificationEdges = getAllClassificationEdges(instanceVertex);
if (instanceVertex == null || !instanceVertex.exists()) {
LOG.warn("deleteAllClassifications(): skipping vertex - already removed");
return;
}

List<AtlasEdge> classificationEdges;

try {
classificationEdges = getAllClassificationEdges(instanceVertex);
} catch (IllegalStateException e) {
LOG.warn("deleteAllClassifications(): skipping vertex - already removed", e);
return;
}

boolean isImportInProgress = RequestContext.get().isImportInProgress();

for (AtlasEdge edge : classificationEdges) {
Expand Down
Loading