Repository navigation
GH-55113: [CI][R] Install tzdata-legacy if available so tests are able to find required timezones - #55114
GH-55113: [CI][R] Install tzdata-legacy if available so tests are able to find required timezones#55114raulcd wants to merge 1 commit into
Conversation
…re able to find required timezones
|
@thisisnic just a minor fix to CI |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, checks package availability before installation, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates R CI container setup to restore legacy timezones such as EST, addressing the missing-timezone failure reported in #55113.
Changes:
- Installs
tzdata-legacywhen usingapt-getand the package is available. - Leaves other package managers and systems without the package unchanged.
| File | Description |
|---|---|
ci/scripts/r_docker_configure.sh |
Adds conditional installation of legacy timezone data for R tests. |
Review effort: Balanced
|
Thanks for fixing this! The change makes sense, but I'm wondering if it's gonna be slightly more efficient to just do a text-replace swapping out "EST" for "America/New_York" and avoid installing another dependency? |
|
both sound good to me. We already install $ grep -R "tzdata-legacy" ci/
ci/docker/python-wheel-manylinux-test.dockerfile: tzdata-legacy && \
ci/docker/ubuntu-24.04-cpp-minimal.dockerfile: tzdata-legacy \
ci/docker/debian-13-cpp.dockerfile: tzdata-legacy \
ci/docker/ubuntu-24.04-cpp.dockerfile: tzdata-legacy \
ci/docker/conda.dockerfile: tzdata-legacy \
ci/docker/debian-experimental-cpp.dockerfile: tzdata-legacy \ |
Yeah, in that case, I think it doesn't matter at all actually which, so have approved |
Rationale for this change
GH runner upgrade from Ubuntu 24.04 to 26.04 made some R tests fail due to missing timezone. (Rhub)
What changes are included in this PR?
Install
tzdata-legacypackage if available to have the required timezone.Are these changes tested?
Yes on CI
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: