Skip to content

GH-55113: [CI][R] Install tzdata-legacy if available so tests are able to find required timezones - #55114

Open
raulcd wants to merge 1 commit into
apache:mainfrom
raulcd:GH-55113
Open

raulcd wants to merge 1 commit into
apache:mainfrom
raulcd:GH-55113

Conversation

@raulcd

@raulcd raulcd commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Rationale for this change

GH runner upgrade from Ubuntu 24.04 to 26.04 made some R tests fail due to missing timezone. (Rhub)

What changes are included in this PR?

Install tzdata-legacy package if available to have the required timezone.

Are these changes tested?

Yes on CI

Are there any user-facing changes?

No

Was AI used for this PR?

In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Oct 23, 2026
@raulcd raulcd added the CI: Extra: R Run extra R CI label Oct 23, 2026
@raulcd
raulcd marked this pull request as ready for review October 23, 2026 10:42
@raulcd
raulcd requested review from thisisnic and a balanced review from Copilot October 23, 2026 10:42
@raulcd

raulcd commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

@thisisnic just a minor fix to CI

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped, checks package availability before installation, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

Updates R CI container setup to restore legacy timezones such as EST, addressing the missing-timezone failure reported in #55113.

Changes:

  • Installs tzdata-legacy when using apt-get and the package is available.
  • Leaves other package managers and systems without the package unchanged.
File Description
ci/​scripts/​r_docker_configure.sh Adds conditional installation of legacy timezone data for R tests.

Review effort: Balanced

@thisisnic

Copy link
Copy Markdown
Member

Thanks for fixing this! The change makes sense, but I'm wondering if it's gonna be slightly more efficient to just do a text-replace swapping out "EST" for "America/New_York" and avoid installing another dependency?

@raulcd

raulcd commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

both sound good to me. We already install tzdata-legacy on several other places :)

$ grep -R "tzdata-legacy" ci/
ci/docker/python-wheel-manylinux-test.dockerfile:        tzdata-legacy && \
ci/docker/ubuntu-24.04-cpp-minimal.dockerfile:        tzdata-legacy \
ci/docker/debian-13-cpp.dockerfile:        tzdata-legacy \
ci/docker/ubuntu-24.04-cpp.dockerfile:        tzdata-legacy \
ci/docker/conda.dockerfile:    tzdata-legacy \
ci/docker/debian-experimental-cpp.dockerfile:        tzdata-legacy \

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@thisisnic

thisisnic commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

both sound good to me. We already install tzdata-legacy on several other places :)

$ grep -R "tzdata-legacy" ci/
ci/docker/python-wheel-manylinux-test.dockerfile:        tzdata-legacy && \
ci/docker/ubuntu-24.04-cpp-minimal.dockerfile:        tzdata-legacy \
ci/docker/debian-13-cpp.dockerfile:        tzdata-legacy \
ci/docker/ubuntu-24.04-cpp.dockerfile:        tzdata-legacy \
ci/docker/conda.dockerfile:    tzdata-legacy \
ci/docker/debian-experimental-cpp.dockerfile:        tzdata-legacy \

Yeah, in that case, I think it doesn't matter at all actually which, so have approved

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge CI: Extra: R Run extra R CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants