Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes #54924. An extension array would not round-trip correctly through ArraySpans as a test demonstrates.
What changes are included in this PR?
This fixes the
HasVariadicBuffersimplementation to correctly handle extension types. A test demonstrating the fix is also included.The fix follows the implementation of
ArraySpan::SetMembers, where the same additional case for extension types is includedAre these changes tested?
Yes. By the existing test suite plus an additional test.
Are there any user-facing changes?
None other than the bug fix.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
An LLM suggested the second fix for
in
ArraySpan::SetMembers, which does look correct to me.HasVariadicBuffersshould respect extension types #54924