Repository navigation
GH-54571: [GLib] Add support for returning string view array from C++ - #54572
Merged
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix follows existing dispatch patterns and includes regression coverage; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes the GLib wrapper dispatch that caused Ruby casts to string_view to abort, addressing #54571.
Changes:
- Maps C++ string-view arrays to
GArrowStringViewArray. - Adds a regression test covering wrapper type, values, and nulls.
- Corrects two type names in documentation comments.
| File | Description |
|---|---|
| c_glib/test/test-cast.rb | Adds string-view cast regression coverage. |
| c_glib/arrow-glib/basic-array.cpp | Adds string-view dispatch and corrects documentation names. |
Review effort: Balanced
Member
Author
|
+1 Confirmed: #54571 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
garrow_array_new_raw_valist()misses string view array detection. If we miss it, we can't return a string view array from C++ to GLib.What changes are included in this PR?
Add missing string view array detection.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: