Add new parquet tests based on updated variant/json files - #10785
Merged
Conversation
github-actions
Bot
added
parquet
sdf-jkl
changed the title
Contributor
|
maybe we can make a separate PR to just update parquet-testing (to get the latest files)? |
Contributor
Author
|
I'll do just that and file an issue to track adding the tests 👍 |
…-parquet-testing # Conflicts: # parquet-variant/src/variant/metadata.rs # parquet-variant/src/variant/object.rs
sdf-jkl
marked this pull request as ready for review
September 2, 2026 02:27
Contributor
Author
|
@Jefffrey @Rich-T-kid PTAL |
Jefffrey
changed the title
Jefffrey
approved these changes
Sep 2, 2026
Contributor
Author
|
🚀 |
Contributor
|
thanks @sdf-jkl |
Contributor
|
late to the party but nice PR @sdf-jkl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
parquet-testingrevision.Rationale for this change
The updated
parquet-testingrevision included:valuecolumns.#10786 made these fixtures available to Arrow Rust, but did not exercise the JSON, BSON, or malformed Variant files.
The same revision also added an extended ALP fixture. That fixture is covered by the ALP encoder/decoder work in #9372, where the required decoding support exists.
What changes are included in this PR?
bad_data/variants, including the one valid duplicate-offset case and 13 malformed cases.The four shredded Variant cases renamed as invalid by the same
parquet-testingupdate are already exercised by the existing Variant integration harness.Are these changes tested?
Yes. The Parquet and Variant integration tests pass locally, along with formatting and clippy checks. The PR's CI checks are also green.
Are there any user-facing changes?
No. This PR only adds integration-test coverage for existing
parquet-testingfixtures.AI usage
This PR was prepared with OpenAI Codex and reviewed by a human. The integration tests, formatting, and clippy checks described above were run against the final branch, and the GitHub CI checks passed.