Add doc example for multipart upload to GoogleCloudStorage::create_multipart#803
Open
alamb wants to merge 1 commit into
Open
Add doc example for multipart upload to GoogleCloudStorage::create_multipart#803alamb wants to merge 1 commit into
GoogleCloudStorage::create_multipart#803alamb wants to merge 1 commit into
Conversation
…ltipart Add a runnable (`no_run`) example on the `MultipartStore` impl for `GoogleCloudStorage` showing the full low-level flow: `create_multipart`, `put_part` for each part, and `complete_multipart` to finalize. Also link to the example from `MultipartStore::create_multipart` so it is discoverable from the trait definition. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kevinjqliu
approved these changes
Jul 18, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, slight nit on the the documentation for gcs multipart upload limits
| /// [`ObjectStoreExt::put_multipart`]: crate::ObjectStoreExt::put_multipart | ||
| /// [`complete_multipart`]: MultipartStore::complete_multipart | ||
| /// [`abort_multipart`]: MultipartStore::abort_multipart | ||
| /// [Cloud Storage multipart upload limits]: https://cloud.google.com/storage/docs/multipart-uploads |
Contributor
There was a problem hiding this comment.
Suggested change
| /// [Cloud Storage multipart upload limits]: https://cloud.google.com/storage/docs/multipart-uploads | |
| /// [Cloud Storage multipart upload limits]: https://docs.cloud.google.com/storage/docs/xml-api/post-object-complete |
nit i find this page to be more useful: https://docs.cloud.google.com/storage/docs/xml-api/post-object-complete
it explicitly states the limitation about 5mib
If one of the parts specified in the request is less than 5 MiB and is not the final part in the upload, you get a 400 Bad Request status code and the body of the error response has InvalidArgument in the Code element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The low-level
MultipartStoreAPI had no worked example showing the fullcreate_multipart→put_part→complete_multipartflow. This adds one for Google Cloud Storage, mirroring the S3 example in #801.What changes are included in this PR?
no_run) doc example onGoogleCloudStorage::create_multipartshowing the full low-level flow.Are there any user-facing changes?
Documentation only. No API changes.