Repository navigation
fix(cmake): align minimum version and improve flatcc discovery - #992
Draft
paleolimbot wants to merge 1 commit into
Draft
paleolimbot wants to merge 1 commit into
paleolimbot wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 106 106
Lines 17153 17153
Branches 2043 2043
=======================================
Hits 13482 13482
Misses 2422 2422
Partials 1249 1249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #949 by requiring CMake 3.18 for find_library(REQUIRED), guarding CMP0135 by availability, and discovering unsuffixed Debug flatcc runtimes before falling back to Release. Update the library-directory description for shared runtimes.
Add build-time IPC smoke tests covering external static/shared runtimes, static preference, Debug/Release, both directory options, and missing libraries, with cross-platform CI. Package exports remain scoped to #963.
Validated on Linux with CMake 3.18.4 and 4.2.3; confirmed the CMake 3.23 policy failure before and successful configuration after. Formatting checks pass. Windows/macOS validation is delegated to CI.