Repository navigation
Conversation
…I build Newer bundled protobuf headers include utf8_validity.h, which lives in third_party/utf8_range of the protobuf source. Add it to the Gandiva JNI include path, like the bundled Abseil headers. Closes apache#1408. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jbonofre
requested review from
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
October 26, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The
JNI macos-15 aarch_64job in the RC workflow fails onmainwithfatal error: 'utf8_validity.h' file not foundwhile compiling the Gandiva JNI library. Apache Arrow C++mainnow bundles protobuf v36.2 (previously v31.1), whoseparse_context.hincludesutf8_validity.hdirectly. That header is inthird_party/utf8_rangeof the bundled protobuf source and was not on the include path.This adds an
ARROW_JAVA_JNI_UTF8_RANGE_INCLUDE_DIRoption, applied to the Gandiva JNI target the same way as the bundled Abseil headers, and sets it injni_macos_build.sh.Not tested locally because it needs the full Arrow C++ build. The
JNI macos-15 aarch_64check on this PR is the verification, and a link error for theutf8_rangesymbols is possible.Closes #1408.
🤖 Generated with Claude Code