Skip to content

GH-1406: Read Float4 values as double and BigDecimal with correct precision #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scruz-denodo wants to merge 1 commit into
base: main
Choose a base branch
from
+81 −6
Open

GH-1406: Read Float4 values as double and BigDecimal with correct precision #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...g/apache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public float getFloat() {

@Override
public double getDouble() {
return this.getFloat();
return Double.parseDouble(Float.toString(this.getFloat()));
}

@Override
Expand All @@ -110,7 +110,7 @@ public BigDecimal getBigDecimal() throws SQLException {
throw new SQLException("BigDecimal doesn't support Infinite/NaN.");
}

return this.wasNull ? null : BigDecimal.valueOf(value);
return this.wasNull ? null : new BigDecimal(Float.toString(value));
}

@Override
Expand All @@ -119,7 +119,9 @@ public BigDecimal getBigDecimal(int scale) throws SQLException {
if (Float.isInfinite(value) || Float.isNaN(value)) {
throw new SQLException("BigDecimal doesn't support Infinite/NaN.");
}
return this.wasNull ? null : BigDecimal.valueOf(value).setScale(scale, RoundingMode.HALF_UP);
return this.wasNull
? null
: new BigDecimal(Float.toString(value)).setScale(scale, RoundingMode.HALF_UP);
}

@Override
Expand Down
79 changes: 76 additions & 3 deletions ...ache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,80 @@ public void testShouldGetDoubleMethodFromFloat4Vector() throws Exception {
accessorIterator.assertAccessorGetter(
vector,
ArrowFlightJdbcFloat4VectorAccessor::getDouble,
accessor -> is((double) accessor.getFloat()));
accessor -> is(Double.parseDouble(Float.toString(accessor.getFloat()))));
}

@Test
public void testShouldGetDoubleThatRoundTripsToTheSameFloat() throws Exception {
accessorIterator.iterate(
vector,
(accessor, currentRow) ->
assertThat((float) accessor.getDouble(), is(accessor.getFloat())));
}

@Test
public void testShouldGetDecimalValuesWithoutFloatWideningArtifacts() throws Exception {
final float[] values = {0.1f, -0.1f, 0.2f, 0.3f, 1.1f, 123.456f, 3.4e-5f, -0.0f};
try (final Float4Vector float4Vector =
new Float4Vector("ID", rootAllocatorTestExtension.getRootAllocator())) {
for (int i = 0; i < values.length; i++) {
float4Vector.setSafe(i, values[i]);
}
float4Vector.setValueCount(values.length);

accessorIterator.iterate(
float4Vector,
(accessor, currentRow) -> {
final String expected = Float.toString(values[currentRow]);
assertThat(accessor.getDouble(), is(Double.parseDouble(expected)));
assertThat(accessor.getObject(Double.class), is(Double.parseDouble(expected)));
assertThat(accessor.getBigDecimal(), is(new BigDecimal(expected)));
assertThat(
accessor.getBigDecimal(9),
is(new BigDecimal(expected).setScale(9, RoundingMode.HALF_UP)));
});
}
}

@Test
public void testShouldGetDoubleFromFloat4VectorWithZeroPointOne() throws Exception {
try (final Float4Vector float4Vector =
new Float4Vector("ID", rootAllocatorTestExtension.getRootAllocator())) {
float4Vector.setSafe(0, 0.1f);
float4Vector.setValueCount(1);

accessorIterator.iterate(
float4Vector,
(accessor, currentRow) -> {
assertThat(accessor.getDouble(), is(0.1));
assertThat(accessor.getBigDecimal(), is(new BigDecimal("0.1")));
assertThat(accessor.getBigDecimal(9), is(new BigDecimal("0.100000000")));
});
}
}

@Test
public void testShouldGetDoubleMethodFromFloat4VectorWithNull() throws Exception {
try (final Float4Vector float4Vector =
new Float4Vector("ID", rootAllocatorTestExtension.getRootAllocator())) {
float4Vector.setNull(0);
float4Vector.setValueCount(1);

accessorIterator.assertAccessorGetter(
float4Vector, ArrowFlightJdbcFloat4VectorAccessor::getDouble, is(0.0));
}
}

@Test
public void testShouldGetDoubleMethodFromFloat4VectorWithNaN() throws Exception {
try (final Float4Vector float4Vector =
new Float4Vector("ID", rootAllocatorTestExtension.getRootAllocator())) {
float4Vector.setSafe(0, Float.NaN);
float4Vector.setValueCount(1);

accessorIterator.assertAccessorGetter(
float4Vector, ArrowFlightJdbcFloat4VectorAccessor::getDouble, is(Double.NaN));
}
}

@Test
Expand All @@ -191,7 +264,7 @@ public void testShouldGetBigDecimalMethodFromFloat4Vector() throws Exception {
if (Float.isInfinite(value) || Float.isNaN(value)) {
assertThrows(SQLException.class, accessor::getBigDecimal);
} else {
assertThat(accessor.getBigDecimal(), is(BigDecimal.valueOf(value)));
assertThat(accessor.getBigDecimal(), is(new BigDecimal(Float.toString(value))));
}
});
}
Expand All @@ -207,7 +280,7 @@ public void testShouldGetBigDecimalWithScaleMethodFromFloat4Vector() throws Exce
} else {
assertThat(
accessor.getBigDecimal(9),
is(BigDecimal.valueOf(value).setScale(9, RoundingMode.HALF_UP)));
is(new BigDecimal(Float.toString(value)).setScale(9, RoundingMode.HALF_UP)));
}
});
}
Expand Down
Loading