Skip to content

MINOR: Move del_branch_on_merge under pull_requests in .asf.yaml - #1394

Merged
jbonofre merged 1 commit into
apache:mainfrom
jbonofre:asf-yaml-del-branch-on-merge
Oct 26, 2026
Merged

jbonofre merged 1 commit into
apache:mainfrom
jbonofre:asf-yaml-del-branch-on-merge

Conversation

@jbonofre

Copy link
Copy Markdown
Member

What's Changed

ASF Infra reports this warning on .asf.yaml:

found legacy setting 'github.del_branch_on_merge' while 'github.pull_requests' is present. Move setting to 'github.pull_requests'

The pull_requests block added in #1392 conflicts with the legacy top-level del_branch_on_merge key. This PR moves the key under github.pull_requests. Branches are still deleted after a PR is merged.

The pull_requests block added in apache#1392 makes the top-level
github.del_branch_on_merge key a legacy setting that ASF Infra
flags. Move it under github.pull_requests; behavior is unchanged.
@jbonofre jbonofre added the chore PRs that make misc changes. label Oct 26, 2026
@github-actions github-actions Bot added this to the 20.0.0 milestone Oct 26, 2026

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jbonofre
jbonofre merged commit 181758c into apache:main Oct 26, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that make misc changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants