Repository navigation
MINOR: Fix validation of decimals at their declared precision - #1342
Merged
Merged
Conversation
robert3005
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
October 12, 2026 12:29
robert3005
changed the title
This comment has been minimized.
This comment has been minimized.
jbonofre
approved these changes
Oct 30, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the fix!
checkPrecisionAndScaleNoThrow now matches the Javadoc and the throwing checkPrecisionAndScale, which fixes the off-by-one at the boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecimalUtilityl#checkPrecisionAndScaleNoThrow used to reject value precision that was equal to the vector precision, it should not.