Repository navigation
Free the imported schemas in the C Data pyarrow import tests - #477
Merged
CurtHagenlocher merged 1 commit intoOct 19, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
All four additions follow the importer’s ownership contract, with no unresolved issues.
No open issues 🎉
What changed in this PR
Fixes unmanaged schema-struct leaks in four pyarrow import tests without changing production code.
Changes:
- Calls
CArrowSchema.Freeimmediately after each schema import, before subsequent imports or assertions.
| File | Description |
|---|---|
| test/Apache.Arrow.Tests/CDataInterfacePythonTests.cs | Frees schemas in array, record batch, GUID, and Bool8 import tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
ImportArray,ImportRecordBatch,ImportGuidArrayandImportBool8ArrayinCDataInterfacePythonTests.csallocate aCArrowSchema, have pyarrow export into it, and import it, but never callCArrowSchema.Free. The importer calls pyarrow's release callback, so what leaked was theCArrowSchemastruct itself. They now free the schema right after importing it, asImportDictionaryOfGuidArraydoes since #474, so a failing assertion can't skip the free.This only changes tests. Every
CArrowSchema.Createin the test projects now has a matchingCArrowSchema.Free.Tests
The full
Apache.Arrow.Testssuite passes on net8.0, net462 and net472, with the pyarrow tests enabled.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com