Helm release docs: keep only latest in dist/release (ASF policy)#67988
Helm release docs: keep only latest in dist/release (ASF policy)#67988potiuk wants to merge 1 commit into
Conversation
potiuk
requested review from
bugraoz93,
jedcunningham,
jscheffl,
shahar1 and
vincbeck
as code owners
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-2-test
|
@potiuk I think this may have removed all the previous versions of the helm charts from the chart repository. https://downloads.apache.org/airflow/helm-chart/ The chart index needs to be updated to point to the archive when a new version is released so that users are not directly forced to get a new chart version. |
Yes. That's what we usually do. It turned out to be a Fastly Cache purge issue. But I am also changing it now to always use archive links not download. Download should only ever contain latest release (so removal was good) it was really the index problem that should always point to archive and it should make it resilient to those kind of issues. |
…e.org
Two fixes to dev/README_RELEASE_HELM_CHART.md, both stemming from ASF's policy
that dist/release and downloads.apache.org only keep the latest release while
archive.apache.org permanently retains every released version.
1. 'Remove old releases' step: it kept the last 2 chart versions and shipped a
broken command ('cd cd', a path that does not match where asf-dist is
checked out, and a single hardcoded PREVIOUS_VERSION). Update it to remove
every version except the one just released, fix the working-copy path to
reuse ${AIRFLOW_SVN_RELEASE_HELM}, and explain why removal must wait until
the new index.yaml is published.
2. 'Update index.yaml in airflow-site' step: the newly released version was
merged into index.yaml with a downloads.apache.org URL. Because downloads
only serves the latest release, those URLs 404 as soon as the next version
ships. Point the merged URL at archive.apache.org/dist instead, matching the
rewrite already applied to existing entries earlier in the doc.
potiuk
force-pushed
the
helm-release-readme-remove-old-releases
branch
from
27b776b to
bc23370
Compare
| for old_version in $(svn ls | sed 's:/$::' | grep -vx "${VERSION}"); do | ||
| svn rm "${old_version}" | ||
| done | ||
| svn commit -m "Remove superseded Helm Chart releases, keeping only ${VERSION} in dist/release per ASF release policy (older releases remain available from https://archive.apache.org/dist/airflow/helm-chart/)" |
There was a problem hiding this comment.
We don't need this detail in every commit message.
| svn commit -m "Remove superseded Helm Chart releases, keeping only ${VERSION} in dist/release per ASF release policy (older releases remain available from https://archive.apache.org/dist/airflow/helm-chart/)" | |
| svn commit -m "Remove superseded Helm Chart releases" |
| Do this only *after* the updated ``index.yaml`` has been published (see the step above), so | ||
| that users who have not yet run ``helm repo update`` are not left pointing at ``dist/release`` | ||
| URLs that now 404 -- it is the published ``index.yaml`` that rewrites old-version URLs to the | ||
| archive. | ||
|
|
There was a problem hiding this comment.
| Do this only *after* the updated ``index.yaml`` has been published (see the step above), so | |
| that users who have not yet run ``helm repo update`` are not left pointing at ``dist/release`` | |
| URLs that now 404 -- it is the published ``index.yaml`` that rewrites old-version URLs to the | |
| archive. |
Everyone uses archive now, we don't need to worry about timing of index.yaml at all.
| # Use archive.apache.org (not downloads.apache.org): downloads only keeps the latest | ||
| # releases, while archive permanently retains every released version even after it is | ||
| # removed from downloads. | ||
| helm repo index --merge ./index.yaml . --url "https://archive.apache.org/dist/airflow/helm-chart/${VERSION}" |
There was a problem hiding this comment.
Is there a delay for the release to be active on archive? For some reason I have a trace of a memory there was and I tried this exact change long ago...
4 participants
The Helm chart release README had two issues, both stemming from ASF's policy that
dist/releaseanddownloads.apache.orgonly keep the latest release, whilearchive.apache.orgpermanently retains every released version.1. "Remove old releases" step
It kept the last 2 chart versions and shipped a broken command:
cd cd, a working-copy path that does not match whereasf-distis actually checked out, and a single hardcodedPREVIOUS_VERSION. This updates the step to:${AIRFLOW_SVN_RELEASE_HELM}(set in the publish step) and drop thecd cdtypo,index.yamlis published (so users who have not runhelm repo updateare not left with 404ing URLs).2. "Update
index.yamlin airflow-site" stepThe newly released version was merged into
index.yamlwith adownloads.apache.orgURL. Because downloads only serves the latest release, those URLs 404 as soon as the next version ships. This points the merged URL atarchive.apache.org/distinstead, matching the rewrite already applied to existing entries earlier in the doc.Docs-only change to
dev/README_RELEASE_HELM_CHART.md.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines