Closed
Conversation
Member
|
Looks like there are changes to other files too not just I ran the javascript formatter command that is run in the build and got the same output for |
utafrali
force-pushed
the
fix/issue-6313-eventually-consistent-batch-scanner-retr
branch
from
a75fe4a to
1e421b6
Compare
dlmarion
requested changes
Apr 16, 2026
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
I'm not sure I understand:
- Why javadoc comments were removed
- Why the text blocks were undone
- The code reorganization
It looks like these changes might be targeted to fix issue #6313, but that issue is already closed at this time. We are happy to accept and review pull requests, but please make a comment on an issue if you are going to work on it to let others know.
Author
|
fair point, didn't realize the issue was already closed - closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick cleanup while working in this file. The columns array had inconsistent spacing - fixed it to match the rest of the codebase.