Repository navigation
send dscp with ecn through a traffic_class feature - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel takes a per-datagram IP_TOS / IPV6_TCLASS as the whole
traffic-class byte. ecn::build wrote only the ECN bits, so every
ECN-marked datagram went out with DSCP zero, overriding any DSCP the
socket had been given.
Add traffic_class, which carries a marking of DSCP and ECN in both
directions, and a dscp enum naming the standard classes. ecn stays for
receive but is no longer sendable, so ECN cannot be marked without
stating the DSCP. Both features share one tos_message for the width
handling, building and enabling.
Breaking: set no longer compiles. Use
set<traffic_class>({.ecn = x}), with a dscp field when one is wanted.