Repository navigation
Feature sm im - #325
Merged
Merged
Feature sm im#325
Conversation
mlohvynenko
force-pushed
the
feature_sm_im
branch
from
November 6, 2026 13:15
09ac983 to
6041db4
Compare
al1img
force-pushed
the
feature_imagemanager
branch
from
November 6, 2026 14:02
013e29a to
ec90358
Compare
mlohvynenko
force-pushed
the
feature_sm_im
branch
from
November 6, 2026 14:40
6041db4 to
e52ba0f
Compare
al1img
approved these changes
Nov 6, 2026
al1img
left a comment
al1img
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mlohvynenko
force-pushed
the
feature_sm_im
branch
3 times, most recently
from
November 6, 2026 18:00
9e2ab2a to
f11a1e5
Compare
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
The SM API returns the info of a single blob now. Return the blob URLs, SHA-256 and size, and put the provider error into the response error info, so SM gets its code, e.g. integrity error. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
The SM image manager stores items and blobs in the common image manager storage. Inherit common::database::Database, which implements it, drop the obsolete update items table, create the image manager items and blobs tables in migration 7 and implement IsLayerUsed. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
cppcheck lint fails with missingOverride on the CM database destructor, which overrides the virtual destructor of the common database now, and with noExplicitConstructor on the fileserver FDHandle constructors. Mark the CM database destructor override and make the FDHandle int constructor explicit. Keep the nullptr constructor implicit, as unique_ptr requires its pointer type to be constructible from nullptr, and suppress the warning for it. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mlohvynenko
force-pushed
the
feature_sm_im
branch
from
November 6, 2026 18:01
f11a1e5 to
ebab9fb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.