-
Notifications
You must be signed in to change notification settings - Fork 62
fix(core): allows postinstall script to run in npm v12 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tobi1220
wants to merge
10
commits into
anthropics:main
Choose a base branch
from
tobi1220:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c6543e1
fix(core): allows postinstall script to run in npm v12
tobi1220 8e80bac
fix: apply npm allow-scripts only on npm v12+
Copilot 7a479d0
Potential fix for pull request finding
tobi1220 75f23e7
Initial plan
Copilot c41e366
test: add scenario covering Node auto-install path
Copilot 2b507ac
Initial plan
Copilot ce0adab
test: add auto-install-node scenario assertions
Copilot d0ff033
Merge pull request #3 from tobi1220/copilot/fix-code-review-comment
tobi1220 5b46f1f
Merge pull request #2 from tobi1220/copilot/fix-review-comment-1
tobi1220 64780f2
Merge pull request #1 from tobi1220/copilot/fix-copilot-comment-in-pr
tobi1220 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| # Validate the auto-install path installed Node.js 18 from NodeSource. | ||
| if ! node --version | grep -q "^v18\."; then | ||
| echo "expected Node.js 18.x from auto-install path" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ ! -f /etc/apt/sources.list.d/nodesource.list ]; then | ||
| echo "expected NodeSource apt source list to exist" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Auto-install Node.js scenario checks passed!" | ||
| exit 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.