Repository navigation
Prepare the 1.0.0rc4 release on stable/27.1 - #664
Merged
Merged
Conversation
Prepare the stable/27.1 branch for the 1.0.0rc4 release. - Rename the Unreleased section to 1.0.0rc4 and set its date to 2026-11-02, the heading format that scripts/check_changelog_date.py requires on the day the release is tagged. - Reword the browser fallback entry to describe what the code does: when the normal browser launch fails, PyDynamicReporting retries once with the packaged browser executable and logs a warning, and it names the incomplete browser build when that executable is missing. - Reword the Playwright security entry so Chromium 156 is only claimed for ADR installations that ship chromium_headless_shell-1248, and Chromium 148 for those that still ship chromium_headless_shell-1223. Verified with: uv run python scripts/check_changelog_date.py 1.0.0rc4 and pre-commit run --files CHANGELOG.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The first ADR 27.1 release ships chromium_headless_shell-1248, so the changelog should not describe installations that ship 1223. The earlier wording came from testing a pre-release ADR build. - Restore the original Playwright security entry: Playwright 1.64.1 uses Chromium 156 (chromium_headless_shell-1248). - Keep the browser fallback entry factual (one retry with the packaged browser, a warning, and an ADRException naming the incomplete build) without claiming it covers ADR 27.1 installations that ship 1223. Verified with: uv run python scripts/check_changelog_date.py 1.0.0rc4 and pre-commit run --files CHANGELOG.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Point the stable/27.1 branch at ghcr.io/ansys/adr_dev:27.1 instead of latest. The ADR build workflow publishes latest only from main, which is now the 27.2 line (FLAGSHIP_VERSION=272), and publishes the 27.1 tag from releases/release-27.1 without touching latest (ADR_IMAGE_TAG=27.1, ADR_PUSH_LATEST=false in the build log). Testing this branch against latest therefore tests it against a different ADR release line that keeps moving. - scripts/pull_adr_image.sh pulls the 27.1 image in CI. - DOCKER_DEV_REPO_URL, used by the tests and by the docker launcher in dev mode, uses the 27.1 image. - DOCKER_REPO_URL, the default image of the docker launcher, also uses the 27.1 image so the 27.1 client defaults to the 27.1 product. The two docker_image literals in tests/test_compatibility.py are left as they are because those tests mock the docker launcher. Verified with: the constants and the pull script agree on the same image, no adr_dev:latest reference remains in src, scripts, .github, or the Makefile, and pre-commit passes on the changed files. The pytest suite was not run locally; CI pulls the image and runs it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…lease Bring the ADR 27.1 image change into the rc4 release-prep branch so stable/27.1 CI and the docker launcher use ghcr.io/ansys/adr_dev:27.1 instead of latest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable/27.1 #664 +/- ##
===============================================
- Coverage 82.06% 82.05% -0.02%
===============================================
Files 32 32
Lines 9422 9422
Branches 1693 1693
===============================================
- Hits 7732 7731 -1
Misses 1194 1194
- Partials 496 497 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://ado.internal.synopsys.com/tfs/ANSYS_development/Portfolio/_workitems/edit/1534172
Summary
stable/27.1branch for the 1.0.0rc4 release: rename the Unreleased changelog section to1.0.0rc4and set its date to 2026-11-02.Notes
scripts/tag_release.shruns (scripts/check_changelog_date.py). If tagging slips past 2026-11-02, a date-only PR is needed, as for rc3.Verification
scripts/check_changelog_date.py 1.0.0rc4, the checktag_release.shruns.pre-commit run --files CHANGELOG.md; every applicable hook passed.uv lock --upgraderefresh fromAGENTS.mdwas intentionally skipped so the locked dependencies stay as released in fix!: security updates and drop Python 3.10 on stable/27.1 #645.