Skip to content

feat(screenshots): Export asks where to save, and recordings dim around their target - #2297

Merged
kitlangton merged 3 commits into
devfrom
export-and-dim
Nov 22, 2026
Merged

kitlangton merged 3 commits into
devfrom
export-and-dim

Conversation

@kitlangton

Copy link
Copy Markdown
Collaborator

Export in the Screenshots editor now asks where to save, and an Area or Window recording dims everything it isn't recording.
Both are in Labs › Screenshots (macOS). Copy is unchanged: it still only goes to the clipboard.

💡 Why
Export wrote a new file into the screenshots folder without saying where, and while you recorded part of the screen nothing showed which part.

🆕 Now you can

  1. Click Export (or a shot's Save) to get the Mac's own save panel, above the editor, in the folder you last saved to and offering the file's own name. Cancel does nothing. The button shows progress only once you've picked a path, and the chosen size and trim go there.
  2. Pick the shot's own file to replace it; the editor closes. Any other path keeps the editor open with "Saved".
  3. Record an Area or a Window and see every display dim except that rect, outlined as the picker outlined it. A window's hole follows the window as you move it. The dim fades in once the screen records and out at stop or cancel, never takes a click or focus, and stays out of the movie (unless "Show in screen recordings" is on). A full-screen recording dims nothing.
- Export -> new file in screenshots folder, silently
+ Export -> save panel (last folder, own name) -> write to the chosen path atomically, or nothing on Cancel
+ Area/Window recording starts -> one click-through dim per display, hole = target, follows the window

📊 Stills (offscreen renders)

Recording a window The picker, for comparison
Recording an area (light) Exporting to the chosen path Saved

New tests cover the offered name, Cancel changing nothing, the chosen path getting the recording, an atomic replace leaving nothing beside it, and the dim waiting for the screen and ending with its recording. The save panel itself and the dim over a real dragged window aren't observed on a real Mac yet.

👀 Read: src/screenshots/dim.rs, the thread that waits for the recording's screen, then follows the window at 16 ms and stops when the recording's bundle changes. The picker's dim drawing moved into a shared function so the recording dim matches it exactly; the own-windows code moved out of capture_host.rs to keep it under its size ceiling. The rest is routine.

Asked for directly · no user reports · the remembered folder is the new screenshots.export_folder setting

Checks run
  • scripts/check screenshot: 81 passed
  • scripts/check capture: 434 passed
  • cargo clippy --bin hex and --tests on macOS: clean
  • Stills rendered with HEX_CAPSULE_SNAPS / HEX_SCREENSHOT_SNAPS
  • check-linux.yml dispatched on the branch for the picker goldens

@kitlangton
kitlangton merged commit 6b48f9d into dev Nov 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant