Repository navigation
feat(screenshots): Export asks where to save, and recordings dim around their target - #2297
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export in the Screenshots editor now asks where to save, and an Area or Window recording dims everything it isn't recording.
Both are in Labs › Screenshots (macOS). Copy is unchanged: it still only goes to the clipboard.
💡 Why
Export wrote a new file into the screenshots folder without saying where, and while you recorded part of the screen nothing showed which part.
🆕 Now you can
📊 Stills (offscreen renders)
New tests cover the offered name, Cancel changing nothing, the chosen path getting the recording, an atomic replace leaving nothing beside it, and the dim waiting for the screen and ending with its recording. The save panel itself and the dim over a real dragged window aren't observed on a real Mac yet.
👀 Read:
src/screenshots/dim.rs, the thread that waits for the recording's screen, then follows the window at 16 ms and stops when the recording's bundle changes. The picker's dim drawing moved into a shared function so the recording dim matches it exactly; the own-windows code moved out ofcapture_host.rsto keep it under its size ceiling. The rest is routine.Asked for directly · no user reports · the remembered folder is the new
screenshots.export_foldersettingChecks run
scripts/check screenshot: 81 passedscripts/check capture: 434 passedcargo clippy --bin hexand--testson macOS: cleanHEX_CAPSULE_SNAPS/HEX_SCREENSHOT_SNAPScheck-linux.ymldispatched on the branch for the picker goldens