Repository navigation
iOS keyboard: the typing replay reports all-words accuracy, contractions and taps read as swipes - #2287
Merged
Conversation
thdxr
force-pushed
the
fix-typing-replay-report
branch
8 times, most recently
from
November 22, 2026 01:00
bb170cf to
602b569
Compare
…ons and taps read as swipes The swipe report's all-words-accuracy divided in-dictionary right words by in-dictionary words. Rename it in-dictionary-accuracy and add an all-words-accuracy over every word, for swipes and taps. right now means the typed word matches regardless of the dictionary; the in-dictionary counters keep their filter. Tap mode keeps Swipe typing attached, so a drifting tap can be promoted. Count those as read-as-swipes from SwipeTyping's active touch. Scoring keeps apostrophes (curly ones straightened) and the dictionary check accepts AutocorrectEngine.englishContractions. Taps compare letters, digits and apostrophes; swipes compare letters only, since a swipe path cannot draw an apostrophe.
…ophes Restore the tap key's ASCII-letter behaviour: digits, numbers and accented letters no longer enter the key, so accuracy for inputs without apostrophes is unchanged. Trim leading and trailing apostrophes so quoted words and plural possessives stay in the dictionary, and keep swipe keys ASCII letters only. Correct the benchmark note: --set test keeps every phone test condition the default filters keep, not every condition in the dataset.
…as one Autocorrect adds apostrophes to recorded words that had none (cant -> can't), and the ASCII tap key made those wrong. tapKey compares apostrophes only when the intended word has one, and align uses the same key per intended-typed pair. A recorded don't still needs its apostrophe.
thdxr
force-pushed
the
fix-typing-replay-report
branch
from
November 22, 2026 01:21
602b569 to
9d8f316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typing replay report had three problems.
all-words-accuracyin swipe mode divided right words by in-dictionary words. It is nowin-dictionary-accuracy, and both modes have a realall-words-accuracyover every recorded word.rightno longer requires the dictionary, so an out-of-dictionary word the field typed correctly counts.typedRight,attempts,tapsand the other in-dictionary counters still filter oninDictionary, andaccuracykeeps its old meaning.read-as-swipescounts the recorded taps the plane promoted, read fromSwipeTyping's active touch before the lift.’, and trims leading and trailing apostrophes, so quoted words ('hello') and plural possessives (dogs') stay in the dictionary. Taps ignore digits, and count an apostrophe only when the recorded word has one: autocorrect'scan'tfor a recordedcantstays right, while a recordeddon'ttypeddontis wrong. Taps on digit or accented input score as before. The dictionary check acceptsAutocorrectEngine.englishContractions, sodon'tis not scored or checked asdont. Swipes compare letters only: a swipe's path runs over letter keys and cannot draw an apostrophe, and the decoder may spell a contraction with or without one, so the letters are the stable comparison. The tradeoff is that a swipe cannot distinguishwellfromwe'll; tap scoring can.Updated
ios/README.mdandios/benchmark/typing-replay/README.mdwith what each accuracy counts and the new fields, and noted that Noisy Typing--set testkeeps every phone test condition the default filters keep (they drop blindfolded,eyesfree_exp2, and the small/tiny keyboards), so its number is not comparable to a normal-space-only sample.docs/featureshas no map that describes these fields.