Skip to content

ci(lint): retry downloading runtime dependencies - #22899

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:22898
Nov 3, 2026
Merged

criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:22898

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6.1-Sol xhigh

Purpose / Description

nativeruntime-dist-compat-1.0.19.jar was downloaded under the 'Run Lint Debug' step

Fixes

Approach

Download it under 'Warm Gradle Cache'

How Has This Been Tested?

  • We're about 3m of job execution - no concerns with timeouts
  • Moved from 137 to 425 tasks - all 228 were previously in 'Run Lint Debug'

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

`nativeruntime-dist-compat-1.0.19.jar` was downloaded under
the 'Run Lint Debug' step

Fixes 22898

Assisted-by: GPT-6.1-Sol xhigh

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assisted-by: Grok 4.7

Thanks — pulling the Robolectric lint-model tasks into the existing warm retry is a clean fix for the CI flake.

Locally I rebased onto main without force-pushing (prep stayed at the PR tip). I ran lint (lintAll, ktlintCheck, lint-rules:test) and unit tests (jacocoUnitTestReport); both passed. Emulator was skipped (workflow-only diff).

Reviewed .github/workflows/lint.yml adding :AnkiDroid:generateFullDebugAndroidTestLintModel and generateDebugAndroidTestLintModel to the nick-fields retry warm step so nativeruntime-dist-compat resolves before lintAll, matching the Run Lint Debug failure in #22898.

some acceptable findings, no action required, just leaving for posterity: unit-test lint model tasks could also be warmed if the test-fixtures classpath edge changes.

@mikehardy mikehardy added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 3, 2026
@criticalAY
criticalAY added this pull request to the merge queue Nov 3, 2026
@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 3, 2026
Merged via the queue into ankidroid:main with commit fb036cb Nov 3, 2026
25 checks passed
@github-actions github-actions Bot added this to the 2.26 release milestone Nov 3, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky CI: lint: debugAndroidTestRuntimeClasspath

3 participants