[criticalAY]

Note

Assisted-by: Opus 5.5

Purpose / Description

After a night mode switch, confirming Add or Delete card type, or the full sync warning, did nothing. Cancelling the warning brought the previous confirmation back.

• Second step of ConfirmationDialog loses callbacks on activity recreation #22714, covering the card template editor. Depends on fix(fields): keep confirmations working after recreation #22876.

Fixes

• Part of ConfirmationDialog loses callbacks on activity recreation #22714

Approach

Each card type page now gets its confirmations as fragment results. The full sync warning replaces the confirmation instead of opening on top of it, so Back on it now closes it too.

How Has This Been Tested?

test (fails without this change) and some more tests :)

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

Assisted-by: Grok 4.7

Thank you — the card-type and field editor recreation fix looks solid, and the new Robolectric tests are a nice touch.

Rebased locally onto current main (clean replay; no force-push). Ran lint (lintAll, ktlintCheck, lint-rules:test), jacocoUnitTestReport, and emulator tests (TEST_RELEASE_BUILD=true via run_emulator_tests.py on emulator-5556 / API35_GAPI); all passed.

ConfirmationDialog now stores requestKey and a result Bundle in arguments so the positive button survives recreation via setFragmentResult, while still running any in-memory confirm when set. On the card template page, add/delete/reposition confirmations register fragment-result listeners on the activity’s FragmentManager; executeWithSyncCheck applies the bundle, and full-sync warnings reuse the same bundle through the dialog back stack. Field editor add/delete/reposition/sort follow the same pattern with saved currentPos. New recreation tests configuration-change to night mode before clicking confirm so a no-op restored button would fail.

some acceptable findings, no action required, just leaving for posterity: rename’s full-sync confirm is still an in-memory Runnable (recreation during rename can still drop it); ConfirmationDialog KDoc still mentions setArgs/setConfirm rather than newInstance; full-sync confirm for card-type add/delete does not reload the previewer (same as the old Runnable path).

[criticalAY]

Leaving it for now until parent is merged