[david-allison]

Note

Assisted-by: GPT-6.1-Sol xhigh

Purpose / Description

• Prep for Improve the "Reposition card type" dialog #22721

Approach

• Extract utils
• Add screenshot tests
• Implement in Compose
• Use in the Backup screen
• Fix an issue: done closed the soft keyboard, rather than submitting the dialog

How Has This Been Tested?

Screenshot tests are 1:1 matching

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• BackupPickerScreenshotTest: 16 changes

All 16 changed screenshots

BackupPickerScreenshotTest

• daily_compare.png
• daily_landscape_compare.png
• daily_large_text_compare.png
• interval_below_minimum_compare.png
• interval_compare.png
• interval_empty_compare.png
• interval_landscape_compare.png
• interval_large_text_compare.png
• interval_maximum_compare.png
• interval_minimum_compare.png
• monthly_compare.png
• monthly_landscape_compare.png
• monthly_large_text_compare.png
• weekly_compare.png
• weekly_landscape_compare.png
• weekly_large_text_compare.png

[david-allison]

[mikehardy]

Assisted-by: Grok 4.7

Thank you — wiring IME Done/Enter through the enabled Save button keeps the incrementer honest without changing the range rules.

Locally I rebased onto main without force-pushing (prep stayed at the PR tip). I ran lint (lintAll, ktlintCheck, lint-rules:test), unit tests (jacocoUnitTestReport), and release emulator tests (TEST_RELEASE_BUILD=true via run_emulator_tests.py on emulator-5556 / API35_GAPI); all passed.

Reviewed the shared Compose IncrementerNumberPicker hosted from IncrementerNumberRangePreferenceCompat, validation in NumberPickerState, backup-picker Roborazzi/input/a11y coverage, and Done/Enter performing the positive button only when in-range so cancel and bad input do not persist.

some acceptable findings, no action required, just leaving for posterity: backup test artifacts under filesDir/backup-picker are write-only; screenshot test header still mentions comparing old vs new picker though it captures the current dialog once.

Screenshot changes have been detected, so leaving this for a good manual look.