[criticalAY]

Note

Assisted-by: Opus 5.5

Purpose / Description

People who turn media sync off on purpose had no way to stop the "Failed to load" snackbar. This adds a "Warn about missing media" switch to Sync settings, on by default, and the old study screen, the new one and the previewers all respect it.

• Part of improve missing media UX #22591

Fixes

• Part of improve missing media UX #22591

Approach

check commit message

How Has This Been Tested?

added tests, one per screen (both failed before the change) and emulator:

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

too many settings on the panel, could we move this under 'fetch media on sync'

@BrayanDSO FYI if you have a better idea

[github-actions]

Important

Maintainers: This PR contains Strings changes

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• PreferencesScreenshotTest: 1 change

All 1 changed screenshots

PreferencesScreenshotTest

• FetchMediaPreferenceDialog_never_compare.png

[david-allison]

I... don't understand, sorry

[david-allison]

I was thinking in this location, but not absolute slop

[BrayanDSO]

Is that a real issue?

[criticalAY]

That was wrong screenshot, but I liked your idea too here is what I had in my mind

fetch media(always) no new setting:

fetch media(always): switch is shown

[criticalAY]

Is that a real issue?

• Yes imo, also the message is already limited to twice per study session, so it's a mild annoyance. David suggested the switch on improve missing media UX #22591 for people who turn media sync off on purpose.

[ZornHadNoChoice]

Is the "Display synchronization status" option necessary? We can at least remove an option and add a new one!

Also, I think that "Automatic synchronization" should be the first toggle.

[david-allison]

We were having users lose their data, so wanted a red dot if a user was not signed in to AnkiWeb

Some users got frustrated about not being able to dismiss the "red dot" if they don't use AnkiWeb.

I'd support changing this to a persistent local backup option once we support these backups (probably 2.27, I've been putting it off).

[BrayanDSO]

so it's a mild annoyance.

It's a reminder to either sync or fix the issue. I don't see the value of disabling it forever.

[criticalAY]

Moved it into the “Fetch media on sync” dialog like your mock @david-allison :

[ZornHadNoChoice]

Not a fan of this design. It's very unusual.

[mikehardy]

Assisted-by: grok-4.7
strings_pass@8b50f0c1226b35293d610ef6c79479cc59579a48

Thank you — nesting the switch under Never matches David’s mock, and the default keeps the snackbar for existing Never users until they turn it off.

Locally I rebased one commit onto main without force-push (push: no). Lint passed (lintAll, ktlintCheck, lint-rules:test), unit passed (jacocoUnitTestReport), and emulator passed (TEST_RELEASE_BUILD=true on emulator-5556 / API35_GAPI). GitHub CI on this head still had pending jobs when I checked; merge pending CI.

Reviewed diff: preferences_sync.xml swaps the fetch-media row to FetchMediaPreference with a dialog that uses three radio buttons plus a “warn about missing media” switch shown only for Never; OK/Cancel persist enum choice and the boolean. Prefs.showMissingMediaWarnings gates the could-not-find snackbar in both AbstractFlashcardViewer and CardViewerFragment. Tests cover dialog OK/cancel/recreation, previewer snackbar on/off, and a screenshot of the Never dialog.

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

some acceptable findings, no action required, just leaving for posterity: missing_media_warning_key is not in AnalyticsConstants.reportablePrefKeys; AbstractFlashcardViewerTest only asserts the snackbar is absent; OK writes warnAboutMissingMedia even when the saved choice is not Never; shorter commit subject would fit conventional length prefs.

Screenshot changes have been detected, so leaving this for a good manual look.

[david-allison]

Also not a fan of the design, my point was that it belonged on the dialog, under 'never' [probably as an options menu], but not with the current design