[Ratnesh5]

Note

Assisted-by: Claude Sonnet

Purpose / Description

Migrates SharedDecksActivity to use SafeWebViewLayout to address [MissingOnRenderProcessGone] from #22091.

• Adds clearHistory() and setDownloadListener() delegates to SafeWebViewLayout.
• Implements OnWebViewRecreatedListener on SharedDecksActivity to re-apply WebView settings and reload the URL on recovery.
• Replaces SharedDeckWebViewClient base class with SafeWebViewClient and teardown with binding.webView.safeDestroy().
• Adds unit tests to SharedDecksActivityTest covering render process crash recovery and destroy cleanup.

Fixes

• Part of Handle onRenderProcessGone for all WebViews [MissingOnRenderProcessGone] #22091

Approach

1. Updated activity_shared_decks.xml to use SafeWebViewLayout.
2. Implemented OnWebViewRecreatedListener in SharedDecksActivity.kt.
3. Added delegates clearHistory() and setDownloadListener(...) in SafeWebViewLayout.kt.
4. Added unit tests for crash recovery and destruction in SharedDecksActivityTest.kt.

How Has This Been Tested?

• :AnkiDroid:testPlayDebugUnitTest --tests com.ichi2.anki.shareddeck.SharedDecksActivityTest (all 4 passed)
• :AnkiDroid:testPlayDebugUnitTest --tests com.ichi2.anki.workarounds.SafeWebViewLayoutTest (all 9 passed)
• ktlintMainSourceSetCheck & ktlintTestSourceSetCheck (all passed)

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report: Previous regressions were resolved by the latest commit.

[mikehardy]

Assisted-by: prep verification (near-frontier withheld — unit red on act SHA)

Thanks for the shared-decks SafeWebView work.

Checked out the PR branch and rebased cleanly onto current ankidroid/main without pushing. On LOCAL_TIP 6c3fa6c18188ed74c7cde9a1a6f97729b634abab (act SHA remains PRE_TIP f04626c507f25c777c06982ba08cb08ecfe20646): ./gradlew -p buildSrc test, lintAll / ktlintCheck / lint-rules:test, and jacocoUnitTestReport on emulator-5554 / API36_GAPI_PS16K (cold-boot). Lint passed; unit failed.

SharedDecksDownloadFragmentTest.rate limited download with an AnkiDroid login redirects the WebView to the login page fails with ClassCastException: com.ichi2.anki.SafeWebViewLayout cannot be cast to android.webkit.WebView at SharedDecksDownloadFragmentTest.kt:384. The same test is red on all three GitHub JUnit jobs for this tip. Solo rerun of that test on current main passes, so this looks PR-caused after swapping the activity layout to SafeWebViewLayout.

Please update the fragment test (and any WebView-typed lookup) to match the new container, or expose the embedded WebView the way SharedDecksActivityTest already does. I am not approving while unit CI is red on this SHA.

[mikehardy]

Conflict in AnkiDroid/src/main/java/com/ichi2/anki/workarounds/SafeWebViewLayout.kt: both sides added the same canGoBack() (warnIfNotActive("canGoBack"), then webView.canGoBack()). The PR also added clearHistory() and setDownloadListener(DownloadListener?) in that hunk.

Resolution: kept canGoBack() once and kept those two PR methods unchanged. upstream/main moved during validation (7aa9e51e56 to 212cf6a2af) with no overlapping files, so the same resolution was replayed cleanly. Pushed e77fb98bc6ae403480cd520171f56e3027a4cd58.

Pre-push, API33_GAPI (emulator-5554):

• ./gradlew lintAll ktlintCheck lint-rules:test jacocoUnitTestReport exit 0
• TEST_RELEASE_BUILD=true python3 .github/run_emulator_tests.py exit 0
• Ignored only phone-AVD XML harness failures: DeckPickerTest.checkIfStudyOptionsIsDisplayedOnTablet, NoteEditorTabOrderTest.testTabOrder, PagesTest.activityOpens, NoteTypeFieldEditorContextMenuTest.showsAllOptions, PreferencesNavigationTest.testOnNonCompactMode, DeckPickerImportTest tablet assumption. No other failures.

Assisted-by: Grok 4.7 Medium

[mikehardy]

Assisted-by: grok-4.7-medium

Thanks for iterating on the shared-decks WebView fix.

I did not check out or rebase this tip locally, and I did not run lint, unit, or emulator Gradle lanes on this SHA (prep stopped on required-red CI before local validation).

The diff still centers on SharedDecksActivity, the SafeWebViewLayout workaround, activity_shared_decks.xml, and the shared-deck unit tests that exercise the WebView container.

Blocker: the required GitHub Actions compare job is failing on 0058328ed65b85d01468cb25411ce2d59dcc934a. Please fix the screenshot regression or update baselines so compare is green before we can approve.

[Ratnesh5]

Thanks @mikehardy!
Fixed the SharedDecksScreenshotTest, it had a direct cast to WebView on R.id.web_view which caused a ClassCastException with SafeWebViewLayout. Updated it to reference the inner WebView, verified locally with -Pscreenshot, and pushed the update.

[david-allison]

GPT-6 felt the back button needed improving

    @Test
    fun `back exits while the recovered WebView is loading`() {
        val activity = startSharedDecks()
        val initialWebView = activity.webView
        val homeUrl = getResourceString(R.string.shared_decks_url)
        val deckUrl = "https://ankiweb.net/shared/info/1"

        shadowOf(initialWebView).pushEntryToHistory(homeUrl)
        initialWebView.webViewClient.doUpdateVisitedHistory(initialWebView, homeUrl, false)
        assertFalse(activity.onBackPressedDispatcher.hasEnabledCallbacks())

        shadowOf(initialWebView).pushEntryToHistory(deckUrl)
        initialWebView.webViewClient.doUpdateVisitedHistory(initialWebView, deckUrl, false)
        assertTrue(initialWebView.canGoBack())
        assertTrue(activity.onBackPressedDispatcher.hasEnabledCallbacks())

        // Invoke the installed client, as Android does when the renderer exits.
        assertTrue(initialWebView.webViewClient.onRenderProcessGone(initialWebView, mock()))
        assertNotSame(initialWebView, activity.webView)
        assertFalse(activity.webView.canGoBack())
        assertFalse(activity.isFinishing)

        // Robolectric has not delivered the replacement page's history callback yet.
        activity.onBackPressedDispatcher.onBackPressed()

        assertTrue(activity.isFinishing, "Back should exit while the replacement WebView has no history")
    }

[david-allison]

CI is failing

[Ratnesh5]

Hi @mikehardy I have pushed the updates and changes as requested, could you review whenever you get time

[david-allison]

Thanks!!

done

[mikehardy]

Assisted-by: Grok 4.7

Thank you — SafeWebViewLayout recovery plus fixing Back after renderer death closes the shared-decks crash loop.

Locally I rebased onto main without force-pushing (prep stayed at the PR tip). I ran lint (lintAll, ktlintCheck, lint-rules:test), unit tests (jacocoUnitTestReport), and release emulator tests (TEST_RELEASE_BUILD=true via run_emulator_tests.py on emulator-5556 / API35_GAPI); all passed.

Reviewed SharedDecksActivity hosting SafeWebViewLayout, render-process recreation reloading the home URL, back callback disabled after recovery until history returns, and tests/screenshots using the inner WebView.

some acceptable findings, no action required, just leaving for posterity: one commit title oversells activity support; copyBackForwardList bypasses activeWebView; a shorter subject for the shared-deck fix commit.