Skip to content

fix(note-editor): edge to edge - lower toolbar - #21680

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:note-editor-edge-to-edge
Sep 2, 2026
Merged

fix(note-editor): edge to edge - lower toolbar#21680
criticalAY merged 1 commit into
ankidroid:mainfrom
david-allison:note-editor-edge-to-edge

Conversation

@david-allison

@david-allison david-allison commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Note

Assisted-by: Assisted-by: Claude Fable 5

Purpose / Description

After 7a0baf7 the toolbar was higher when using gesture navigation.

Fixes

Approach

Use a more accurate function and focus on horizontal clearance, rather than vertically clearing the rounded corners.

How Has This Been Tested?

My Pixel 9 Pro, API 37

🚧 Screenshot tests should do the work here.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
fix(note-editor): edge to edge - lower toolbar
cb9ca08 
After 7a0baf7
the toolbar was higher when using gesture navigation.

Use a more accurate function and focus on horizontal clearance,
 rather than moving the toolbar above the rounded corners.

Fixup of 21596
Fixes 21503
Part of 17334

Assisted-by: Claude Fable 5
@david-allison david-allison added Review High Priority Request for high priority review Needs Review labels Sep 1, 2026
@david-allison
david-allison marked this pull request as draft September 1, 2026 01:49
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • NoteEditorScreenshotTest: 1 change
All 1 changed screenshots

NoteEditorScreenshotTest

  • gesture_navigation_compare.png

@david-allison

david-allison commented Sep 1, 2026

Copy link
Copy Markdown
Member Author
gesture_navigation_compare

@david-allison
david-allison marked this pull request as ready for review September 1, 2026 02:02
@david-allison david-allison added this to the 2.25 release milestone Sep 1, 2026
ericli3690
ericli3690 approved these changes Sep 2, 2026
View reviewed changes

@ericli3690 ericli3690 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ericli3690 ericli3690 added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 2, 2026
criticalAY
criticalAY approved these changes Sep 2, 2026
View reviewed changes

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@criticalAY
criticalAY added this pull request to the merge queue Sep 2, 2026
Merged via the queue into ankidroid:main with commit e3e52af Sep 2, 2026
21 checks passed
@github-actions github-actions Bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Sep 2, 2026
@david-allison
david-allison deleted the note-editor-edge-to-edge branch September 2, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@criticalAY criticalAY criticalAY approved these changes
@ericli3690 ericli3690 ericli3690 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.25 release

Development

Successfully merging this pull request may close these issues.

Edge to edge: verify NoteEditorActivity

3 participants

@david-allison @criticalAY @ericli3690