Repository navigation
test[DeckPickerContextMenu]: load the backend so the test can run first - #21604
Merged
david-allison merged 1 commit intoAug 26, 2026
Merged
david-allison merged 1 commit into
david-allison merged 1 commit into
Conversation
4 of 5 tasks
Member
|
What do you think about fixing this upstream? |
Member
|
You can use |
criticalAY
force-pushed
the
fix/deck-picker-context-menu-backend
branch
from
August 26, 2026 18:46
5644ce5 to
f382052
Compare
Contributor
Author
Yeah makes more sense. Will review the PR upstream give me few hours |
david-allison
approved these changes
Aug 26, 2026
david-allison
left a comment
Member
There was a problem hiding this comment.
I'm an "approve" here regardless, if there's a TODO: PERF to move it can be done
DeckPickerContextMenuTest extended no test base class, so the rust backend was never loaded for it. It only passed when some test which does load it happened to run earlier in the same JVM. Test class discovery order is filesystem dependent, so an unrelated new test class elsewhere in the tree can push it to the front and turn the macOS JUnit job red while ubuntu and windows stay green. JvmTest loads the backend in its fixture, so the class stands on its own. Part of ankidroid#14796 Assisted-by: Claude Opus 5
criticalAY
force-pushed
the
fix/deck-picker-context-menu-backend
branch
from
August 26, 2026 19:44
f382052 to
d6fa5f8
Compare
david-allison
approved these changes
Aug 26, 2026
david-allison
enabled auto-merge
August 26, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5
Purpose / Description
DeckPickerContextMenuTestdoes not extendRobolectricTest, so it never callsRustBackendLoader.ensureSetup(). It only passes when some test that does happens to run earlier in the same JVM. When it runs first, every one of its tests dies on:Fixes
RunWith(AndroidJUnit4::class)#14796How Has This Been Tested?
CI and here:
./gradlew :AnkiDroid:testPlayDebugUnitTest --tests "com.ichi2.anki.dialogs.DeckPickerContextMenuTest"Checklist