docs: expand accessibility props in README#433
Merged
Conversation
|
Size Change: 0 B Total Size: 9.51 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 4 4
Lines 194 194
Branches 65 65
=======================================
Hits 186 186
Misses 4 4
Partials 4 4 🚀 New features to boost your workflow:
|
0582f9a to
b4016b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role,tabIndex,id,aria-*) consistent with the rest of the props tablearia-labelandaria-labelledbypatternsContext
Companion to #432, which adds the accessibility props to the component. The README in that PR used a single grouped row which would not be found by someone scanning the table for
roleortabIndexby name, and had no usage guidance for consumers implementing screen reader support for the first time.