Repository navigation
Conversation
MeAkib
commented
Oct 27, 2026
- The statsJson option writes 'browser-stats.json', and 'server-stats.json' when server rendering is enabled, since the stats output was split per platform. The description still names a 'stats.json' file that is never created.
- The browser-esbuild builder delegates to the esbuild based build pipeline, which writes a 'browser-stats.json' file containing an esbuild metafile. The description still names a 'stats.json' file and suggests analyzing it with 'webpack-bundle-analyzer', which does not understand the metafile format.
…ed files The statsJson option writes 'browser-stats.json', and 'server-stats.json' when server rendering is enabled, since the stats output was split per platform. The description still names a 'stats.json' file that is never created.
…n description The browser-esbuild builder delegates to the esbuild based build pipeline, which writes a 'browser-stats.json' file containing an esbuild metafile. The description still names a 'stats.json' file and suggests analyzing it with 'webpack-bundle-analyzer', which does not understand the metafile format.
There was a problem hiding this comment.
Code Review
This pull request updates the descriptions for the statsJson option in the schema files of both the application and browser-esbuild builders. The descriptions now accurately reflect that a 'browser-stats.json' file (and a 'server-stats.json' file when server rendering is enabled) is generated instead of 'stats.json', and the recommended analysis tool has been updated to esbuild's analyzer. There are no review comments, and I have no feedback to provide.
alan-agius4
left a comment
There was a problem hiding this comment.
Please make the last commit (9dea570) a fixup! commit targeting 471cc55 (docs(@angular/build): correct statsJson description to name the emitted files) — e.g. git commit --amend -m "fixup! docs(@angular/build): correct statsJson description to name the emitted files" (or git commit --fixup 471cc5568c88167ad32fd56b3d158e78cebffe12).
9dea570 to
a28401f
Compare
Thanks @alan-agius4, applied your wording. |
…n description (#34541) The browser-esbuild builder delegates to the esbuild based build pipeline, which writes a 'browser-stats.json' file containing an esbuild metafile. The description still names a 'stats.json' file and suggests analyzing it with 'webpack-bundle-analyzer', which does not understand the metafile format. PR Close #34541
…n description (angular#34541) The browser-esbuild builder delegates to the esbuild based build pipeline, which writes a 'browser-stats.json' file containing an esbuild metafile. The description still names a 'stats.json' file and suggests analyzing it with 'webpack-bundle-analyzer', which does not understand the metafile format. PR Close angular#34541