Skip to content

docs(@angular/build): correct statsJson description to name the emitted files - #34541

Closed
MeAkib wants to merge 3 commits into
angular:mainfrom
MeAkib:docs/stats-json-file-names
Closed

MeAkib wants to merge 3 commits into
angular:mainfrom
MeAkib:docs/stats-json-file-names

Conversation

@MeAkib

@MeAkib MeAkib commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
  • The statsJson option writes 'browser-stats.json', and 'server-stats.json' when server rendering is enabled, since the stats output was split per platform. The description still names a 'stats.json' file that is never created.
  • The browser-esbuild builder delegates to the esbuild based build pipeline, which writes a 'browser-stats.json' file containing an esbuild metafile. The description still names a 'stats.json' file and suggests analyzing it with 'webpack-bundle-analyzer', which does not understand the metafile format.

…ed files

The statsJson option writes 'browser-stats.json', and 'server-stats.json' when
server rendering is enabled, since the stats output was split per platform.
The description still names a 'stats.json' file that is never created.
…n description

The browser-esbuild builder delegates to the esbuild based build pipeline,
which writes a 'browser-stats.json' file containing an esbuild metafile. The
description still names a 'stats.json' file and suggests analyzing it with
'webpack-bundle-analyzer', which does not understand the metafile format.
@angular-robot angular-robot Bot added area: docs Related to the documentation area: @angular/build labels Oct 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the descriptions for the statsJson option in the schema files of both the application and browser-esbuild builders. The descriptions now accurately reflect that a 'browser-stats.json' file (and a 'server-stats.json' file when server rendering is enabled) is generated instead of 'stats.json', and the recommended analysis tool has been updated to esbuild's analyzer. There are no review comments, and I have no feedback to provide.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 27, 2026

@alan-agius4 alan-agius4 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MeAkib!

Comment thread packages/angular/build/src/builders/application/schema.json Outdated

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the last commit (9dea570) a fixup! commit targeting 471cc55 (docs(@angular/build): correct statsJson description to name the emitted files) — e.g. git commit --amend -m "fixup! docs(@angular/build): correct statsJson description to name the emitted files" (or git commit --fixup 471cc5568c88167ad32fd56b3d158e78cebffe12).

@MeAkib
MeAkib force-pushed the docs/stats-json-file-names branch from 9dea570 to a28401f Compare October 27, 2026 15:34
@MeAkib

MeAkib commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Please make the last commit (9dea570) a fixup! commit targeting 471cc55 (docs(@angular/build): correct statsJson description to name the emitted files) — e.g. git commit --amend -m "fixup! docs(@angular/build): correct statsJson description to name the emitted files" (or git commit --fixup 471cc5568c88167ad32fd56b3d158e78cebffe12).

Thanks @alan-agius4, applied your wording.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2026
@alan-agius4

Copy link
Copy Markdown
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

alan-agius4 pushed a commit that referenced this pull request Oct 27, 2026
…ed files (#34541)

The statsJson option writes 'browser-stats.json', and 'server-stats.json' when
server rendering is enabled, since the stats output was split per platform.
The description still names a 'stats.json' file that is never created.

PR Close #34541
alan-agius4 pushed a commit that referenced this pull request Oct 27, 2026
…n description (#34541)

The browser-esbuild builder delegates to the esbuild based build pipeline,
which writes a 'browser-stats.json' file containing an esbuild metafile. The
description still names a 'stats.json' file and suggests analyzing it with
'webpack-bundle-analyzer', which does not understand the metafile format.

PR Close #34541
angular-robot pushed a commit to angular-robot/angular-cli that referenced this pull request Oct 27, 2026
…n description (angular#34541)

The browser-esbuild builder delegates to the esbuild based build pipeline,
which writes a 'browser-stats.json' file containing an esbuild metafile. The
description still names a 'stats.json' file and suggests analyzing it with
'webpack-bundle-analyzer', which does not understand the metafile format.

PR Close angular#34541
@MeAkib
MeAkib deleted the docs/stats-json-file-names branch October 28, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build area: @angular-devkit/build-angular area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants