Repository navigation
fix(@angular-devkit/core): only invoke smart default provider when value is undefined - #34537
Merged
Merged
Conversation
…lue is undefined Previously, `CoreSchemaRegistry._applySmartDefaults` invoked the smart default provider unconditionally before `CoreSchemaRegistry._set` checked whether the target property already had a defined value. This caused smart default providers to be evaluated even when an option was explicitly provided.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the CoreSchemaRegistry to defer the execution of smart default providers. Instead of immediately invoking the provider, a lazy function is passed to _set, which is only evaluated and resolved (including handling Observables) if the target property is actually undefined or forced. This prevents unnecessary provider calls when a value is already explicitly defined. A corresponding unit test has been added to verify this behavior. There are no review comments to address.
alan-agius4
added
action: review
clydin
approved these changes
Oct 27, 2026
alan-agius4
added
action: merge
Collaborator
Author
Merged
4 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
CoreSchemaRegistry._applySmartDefaultsinvoked the smart default provider unconditionally beforeCoreSchemaRegistry._setchecked whether the target property already had a defined value. This caused smart default providers to be evaluated even when an option was explicitly provided.