Repository navigation
fix: keep pnpm-lock.yaml a single YAML document for Dependabot alerts - #393
Merged
Merged
Conversation
pnpm 12 prepends a packageManagerDependencies document to the lockfile. GitHub's dependency graph parses only that first document, so after #392 merged the graph dropped to 34 packages and the open extract-zip and sprintf-js alerts were auto-closed within seconds without any update (dependabot/dependabot-core#15904). pmOnFail: ignore is the only setting that stops pnpm emitting the env document; the pnpm version is still enforced by the devcontainer, pnpm/action-setup and engines.pnpm. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 12 writes
pnpm-lock.yamlas a two-document YAML stream (env document withpackageManagerDependenciesfirst, dependency graph second). GitHub's dependency-graph parser reads only the first document (dependabot/dependabot-core#15904). After #392 merged:www/package.json, actions), none of the ~900 transitive packagesextract-zip/sprintf-jsalerts were marked fixed four seconds after the merge, whilepnpm auditstill reports thempmOnFail: ignoreis the only pnpm setting that stops the env document being written. It also disables pnpm's switch to thepackageManagerpin, which this repo doesn't rely on: the devcontainer installs the pinned version,pnpm/action-setupreadspackageManager, andengines.pnpmrejects a wrong major.Verified on pnpm 12.14.0: the stripped lockfile passes
pnpm install --frozen-lockfileunchanged, andpnpm install --fix-lockfilerewrites it as a single document. The lockfile diff is exactly the 158 lines pnpm 12 added. Lint passes.After merge, check the graph recovers with:
gh api repos/andykenward/unlike.dev/dependency-graph/sbom --jq '.sbom.packages | length'Remove the setting once GitHub's parser reads the last document.
🤖 Generated with Claude Code