Repository navigation
ChatApp: pre-fill the chat input from a deep-link draft - #58
Merged
Merged
Conversation
The androidTest sources did not compile: - HiltTestRunner uses HiltTestRunner_Application, which Hilt generates only when its compiler runs on the androidTest sources. Add kspAndroidTest(libs.hilt.compiler). - AppFunctionInstrumentationTest used AppFunctions.ContactSearchResult, which does not exist. Use ContactSearchResult. CI does not compile these sources: the instrumentation test steps in .github/workflows/chatapp.yaml are commented out. Test: ./gradlew :app:assembleDebugAndroidTest
Add an optional `draft` query parameter to the chat route and its deep link, so a link such as app://com.example.chatapp/chat/1?draft=Hello%20Alice%21 opens the chat with Alice and puts "Hello Alice!" in the input box. The draft is never sent automatically: the user reviews it and taps Send. fetchSendMessageDetails (android#57) already returns this link as editMessageUri, so the user can edit the message in the app before sending it; this change makes the app handle the draft. Links without a draft, and existing navigate("chat/$id") calls, behave as before. ChatDeepLinkTest checks that the link resolves to MainActivity, that the draft is pre-filled (including non-ASCII text, a line break and characters that need percent-encoding), and that a link without a draft opens the chat with an empty input. Test: ./gradlew :app:connectedDebugAndroidTest \ -Pandroid.testInstrumentationRunnerArguments.class=com.example.chatapp.ChatDeepLinkTest adb shell am start -a android.intent.action.VIEW -p com.example.chatapp \ -d 'app://com.example.chatapp/chat/1?draft=Hello%20Alice%21'
kasiakre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatApp: pre-fill the chat input from a deep-link draft