Skip to content

Add preconfirmation function for sendMessage - #57

Merged
corinac123 merged 10 commits into
android:mainfrom
corinac123:preconf-function
Oct 2, 2026
Merged

corinac123 merged 10 commits into
android:mainfrom
corinac123:preconf-function

Conversation

@corinac123

Copy link
Copy Markdown
Contributor

Add preconfirmation function for sendMessage

@corinac123
corinac123 requested a review from a team as a code owner October 1, 2026 15:22
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/appfunctions/Util.kt Outdated
@corinac123
corinac123 merged commit 0d4760e into android:main Oct 2, 2026
8 checks passed
kasiakre added a commit to kasiakre/appfunctions that referenced this pull request Oct 5, 2026
Add an optional `draft` query parameter to the chat route and its deep
link, so a link such as

  app://com.example.chatapp/chat/1?draft=Hello%20Alice%21

opens the chat with Alice and puts "Hello Alice!" in the input box.
The draft is never sent automatically: the user reviews it and taps
Send.

fetchSendMessageDetails (android#57) already returns this link as
editMessageUri, so the user can edit the message in the app before
sending it; this change makes the app handle the draft. Links without
a draft, and existing navigate("chat/$id") calls, behave as before.

ChatDeepLinkTest checks that the link resolves to MainActivity, that
the draft is pre-filled (including non-ASCII text, a line break and
characters that need percent-encoding), and that a link without a
draft opens the chat with an empty input.

Test:
  ./gradlew :app:connectedDebugAndroidTest \
    -Pandroid.testInstrumentationRunnerArguments.class=com.example.chatapp.ChatDeepLinkTest
  adb shell am start -a android.intent.action.VIEW -p com.example.chatapp \
    -d 'app://com.example.chatapp/chat/1?draft=Hello%20Alice%21'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants