Repository navigation
feat: refine every lane's change in a second session, one tier up - #22
Merged
Merged
Conversation
A lane went straight from delivery-implement to a draft pull request, so the human at the merge gate was the first to review the change and nothing simplified it. A sixth skill, delivery-refine, now runs as the lane's second session: it reviews the change against the task's acceptance criteria, fixes the findings that name a concrete failure, simplifies only the lines the change added without altering behaviour, re-runs validation, and adds a Refinement section to the report that becomes the pull request body. It runs one tier up (chore as build, build as plan, plan as plan), on that tier's harness and model, or on a tier's own reviewer key in tiers.conf, because a reviewer no stronger than the author finds little the author would not. A failed refinement never loses the implementation: the change is published as delivery-implement left it, and the report says so. --no-refine skips it. The session is started by the launcher through harness.sh, so it works on every adapter rather than relying on one harness's subagents. LAUNCHED and WOULD-LAUNCH gain the review harness and model after the lane's model. See ADR-011. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…has a command Found by running delivery-refine on this branch: a tier above with an advisor but no model sent the advisor as the review model, because a tab-split read collapsed the empty field. A custom tier-above is now only chosen when DELIVERY_LANE_CMD is set. Adds tests for both, for the fallback to the lane's harness, and for where.sh reporting a missing delivery-refine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ancelin-code
force-pushed
the
feat/delivery-refine
branch
from
October 22, 2026 21:02
92d2953 to
2d8dae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A lane went straight from
delivery-implementto a draft pull request. Thehuman at the merge gate was the first to review the change, and nothing
simplified it, although that human is the bottleneck the kit is built around.
A sixth skill,
delivery-refine, runs as the lane's second session. It worksin one pass:
and verification-gap lenses.
body.
Design and evidence: ADR-011.
choreis reviewed asbuild,buildasplan,planasplan, on that tier's harness and model.reviewerintiers.confinstead.than self-review, and a stronger reviewer best.
REFINE-FAILED, noted in the report, and the change is published as itwas.
--no-refineskips the session.harness.sh, so itworks on every adapter, rather than on one harness's subagents.
harness_promptnow takes the skill's name from its path.How to review
delivery-refine/SKILL.md. The order is deliberate: fixing beforesimplifying means no effort goes into code about to change. The list of
simplifications to make and to avoid draws on Anthropic's
code-simplifier,Claude Code's
/simplify, EveryInc'sce-simplify-codeandaddyosmani/agent-skills.launch-lanes.sh:refine_forpicks the review harness and model.publish.
LAUNCHEDandWOULD-LAUNCHgain two columns, the reviewharness and model, after the lane's model. The worktree and repository stay
last.
follow.shreads only the id.Unreleased list. The code merges cleanly; whichever lands second needs a
one-line rebase.
fake harness. The first real lanes, on tiroir, will be the first real runs.
How to try it
sh .agents/skills/delivery-orchestrator/scripts/launch-lanes.sh --dry-run a-001 # WOULD-LAUNCH a-001 claude sonnet claude opus ../lanes/repo/a-001 repoThat output assumes
buildmaps tosonnetandplantoopus. A real lane'slog shows
REFINE claude opusbetween the implementation andPUBLISHED.Does it earn its place?
It has not been measured yet, and the kit's rule says it must be. It is on by
default on the strength of the maintainer's practice and of the cross-model
review literature. The phase 6 evaluation adds a
--no-refinearm and comparesfour things: hidden tests passing, human review findings per pull request,
diff size, and cost per lane. If refinement does not reduce human findings or
raise the number of hidden tests passing, it gets turned off by default.