Fix saving to opened files

[AmityWilder]

Files that have been opened cannot be saved; only new files. The reason for this appears to be that the dir field is not assigned when opening a circuit from a file, and thus no directory path is prepended to the filename at save, causing the path to be relative to the root, which is inaccessible (or at least not the location of the actual file).

[anadon]

You're doing great work. I'm sorry I can't keep up right now!

…

On Tue, Feb 10, 2026, 4:04 PM Amy Wilder ***@***.***> wrote: Files that have been opened cannot be saved; only new files. The reason for this appears to be that the dir field is not assigned when opening a circuit from a file, and thus no directory path is prepended to the filename at save, causing the path to be relative to the root, which is inaccessible (or at least not the location of the actual file). ------------------------------ You can view, comment on, or merge this pull request online at: #5 Commit Summary - d92c34c <d92c34c> Remove duplicate, unconditional "input.close()"s - e5f5bd9 <e5f5bd9> Add makefile for easier compiling and cleanup gitignore - 1cc8831 <1cc8831> Add exception message to error dialog - 30f1902 <30f1902> Assign directory path to loaded circuits File Changes (4 files <https://github.com/anadon/JLS/pull/5/files>) - *M* .gitignore <https://github.com/anadon/JLS/pull/5/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947> (7) - *A* Makefile <https://github.com/anadon/JLS/pull/5/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52> (7) - *M* src/jls/JLSStart.java <https://github.com/anadon/JLS/pull/5/files#diff-1eddb4bdb01a90dbe23d50aa664d81fb19ffcbc2d9ae3c4ca39e4989a708bf8a> (7) - *M* src/jls/edit/Editor.java <https://github.com/anadon/JLS/pull/5/files#diff-4c828f1b2a88f49980764b8f7735459b7c0eb521885d70906ffeda44524bbcad> (2) Patch Links: - https://github.com/anadon/JLS/pull/5.patch - https://github.com/anadon/JLS/pull/5.diff — Reply to this email directly, view it on GitHub <#5>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXYEBIWQ2IHJKGJ6ISLZYT4LJBUBAVCNFSM6AAAAACUVLGFD6VHI2DSMVQWIX3LMV43ASLTON2WKOZTHEZDGNJWGEYTCNI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[anadon]

Thank you for this, @AmityWilder — your diagnosis of the save bug was exactly right: open() never assigned the circuit's directory, so saves resolved against the filesystem root and failed for every circuit opened from disk.

Closing this now that everything in it has landed on master, most of it independently before we could get this branch merged:

• The core save fix landed via Opened circuits never get a directory set: Save and checkpoints target the filesystem root #34 (commit 590f124), with the same root-cause analysis you made here.
• The exception message in the save-error dialog arrived with the TellUser/FileAbstractor refactors (Consolidate circuit-file I/O into a single code path #15, Notification and dialog consolidation: one headless-aware reporter; retire ~160 raw JOptionPane sites and the stdout-error habit #81).
• The duplicate input.close() cleanup — the one piece master still needed — was just landed in Land the remaining cleanup from PR #5: drop leftover duplicate input.close() calls #174, with you credited as co-author on the commit.
• The Makefile and .gitignore changes were superseded when the build moved to Maven + Nix.

Sorry this sat as long as it did, and thanks again for the contribution.

---

Generated by Claude Code