Skip to content

Make the confirmation dialog tests reach the cases they name - #128

Merged
amrali-eg merged 3 commits into
masterfrom
test/confirmation-dialog-refusal-panel
Sep 19, 2026
Merged

amrali-eg merged 3 commits into
masterfrom
test/confirmation-dialog-refusal-panel

Conversation

@amrali-eg

Copy link
Copy Markdown
Owner

Summary

  • Test-only. ItBuildsWhenNothingIsRefused used a Shift_JIS file, which the policy refuses, and asserted the absence of prose the dialog no longer uses, so it passed with the refusal panel showing.
  • ItBuildsForAMixOfEveryOutcome only checked that the form had some controls, and its fixtures did not cover every current outcome.

Changes

  • ItBuildsWithoutASourceChoicePanelWhenNothingNeedsOne: an automatically convertible file; asserts the plan (one Convert, no source choice) and that lstRefusedFiles, lstSourceEncoding and btnConfirmSourceEncoding are absent, by control name rather than by prose.
  • TheSummaryShowsEveryOutcomeWithItsCount: 15 files with a different count in each of the five categories (1 ready, 2 need a source, 3 already in target, 4 not identified, 5 cannot be processed safely). Checks the plan summary, the count the dialog shows beside each label, and that only the two Shift_JIS files are offered a source choice. This also gives the source-choice controls a positive control.

Verification

  • Full suite 917/917, 0 warnings.
  • Mutation-tested, each caught by the intended test: refusal panel always built; already-in-target and not-identified counts swapped; "Cannot be processed safely" showing the source-choice count; safe fixture swapped for a refused one. Distinct counts are what let the swap mutations fail.

Limits

🤖 Generated with Claude Code

amrali-eg and others added 3 commits September 20, 2026 01:40
ItBuildsWhenNothingIsRefused used a Shift_JIS file, which the policy refuses,
and asserted the absence of prose the dialog no longer uses, so it passed with
the refusal panel showing. ItBuildsForAMixOfEveryOutcome only checked that the
form had some controls, and its fixtures did not cover every outcome.

The first is replaced by a test with an automatically convertible file that
asserts the plan and the absence of the source-choice controls by name. The
second is replaced by a mix with a different number of files in each of the
five categories, checking the plan summary, the count shown beside each label
and the files offered a source choice.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The nothing-needs-a-source test now asserts the four empty categories are not
listed, so showing zero-count rows fails it. The mixed-outcome fixture says why
each file lands in its category, and the class summary describes the present
purpose instead of what was once untested.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@amrali-eg
amrali-eg merged commit 475843e into master Sep 19, 2026
3 checks passed
@amrali-eg
amrali-eg deleted the test/confirmation-dialog-refusal-panel branch September 19, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant