Make the confirmation dialog tests reach the cases they name - #128
Merged
Merged
Conversation
ItBuildsWhenNothingIsRefused used a Shift_JIS file, which the policy refuses, and asserted the absence of prose the dialog no longer uses, so it passed with the refusal panel showing. ItBuildsForAMixOfEveryOutcome only checked that the form had some controls, and its fixtures did not cover every outcome. The first is replaced by a test with an automatically convertible file that asserts the plan and the absence of the source-choice controls by name. The second is replaced by a mix with a different number of files in each of the five categories, checking the plan summary, the count shown beside each label and the files offered a source choice. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The nothing-needs-a-source test now asserts the four empty categories are not listed, so showing zero-count rows fails it. The mixed-outcome fixture says why each file lands in its category, and the class summary describes the present purpose instead of what was once untested. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ItBuildsWhenNothingIsRefusedused a Shift_JIS file, which the policy refuses, and asserted the absence of prose the dialog no longer uses, so it passed with the refusal panel showing.ItBuildsForAMixOfEveryOutcomeonly checked that the form had some controls, and its fixtures did not cover every current outcome.Changes
ItBuildsWithoutASourceChoicePanelWhenNothingNeedsOne: an automatically convertible file; asserts the plan (oneConvert, no source choice) and thatlstRefusedFiles,lstSourceEncodingandbtnConfirmSourceEncodingare absent, by control name rather than by prose.TheSummaryShowsEveryOutcomeWithItsCount: 15 files with a different count in each of the five categories (1 ready, 2 need a source, 3 already in target, 4 not identified, 5 cannot be processed safely). Checks the plan summary, the count the dialog shows beside each label, and that only the two Shift_JIS files are offered a source choice. This also gives the source-choice controls a positive control.Verification
Limits
🤖 Generated with Claude Code