Repository navigation
fix: docs page layout (backport #42) - #43
Merged
Merged
Conversation
Long values, such as field names in code, cannot wrap. A table with such values was wider than the content column and overflowed it. Wrap each table in a container that scrolls sideways. Narrow tables look the same as before.
Make the table of contents sticky in the content column. A table of contents that is taller than the screen scrolls by itself. The content area had a fixed height, so the sticky table of contents scrolled away with it. The content area now grows with the content and is at least as tall as the screen. Closes #26
Limit images to the width of the content column, so a wide image does not overflow it.
Use a light purple for inline code in dark mode. Desk uses a dark purple that dark mode does not change.
[Medium impact] This PR appears safe to merge. Reviews (1) · Last reviewed commit: "fix: readable inline code in dark mode" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the parts of #42 that also apply to v15.
Not backported, because v15 does not need it:
page.set_breadcrumbs()and the removal of the breadcrumbs polyfill. This API does not exist in v15.