Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a separate, opt-in Filter Low-Level Background Audio preference that prevents sustained faint PCM from reaching streaming or final ASR.
This does not change Skip Silent Recordings. That preference retains its existing post-capture behavior for recordings up to four seconds. Keeping the controls independent avoids surprising users who enabled the older setting for its narrower purpose.
When enabled, the capture pipeline now:
The preference is disabled by default to preserve current behavior for unusually quiet microphones. It is included in settings search and backup/restore, and older backups continue to decode without it.
Type of Change
Related Issue or Discussion
Accepted design Discussion: #990
Testing
swiftlint --strict --config .swiftlint.yml Sources Tests Package.swiftswiftformat --config .swiftformat SourcesRegression coverage includes:
Latency benchmark on Apple Silicon:
Full report and method: https://github.com/aaldrich/FluidVoice/blob/pr-assets/low-level-background-audio-filter/latency-benchmark.md
Screenshots / Video
Notes
The setting is opt-in and disabled by default. Fixed conservative thresholds are used initially; an adaptive noise floor can be considered separately if broader hardware testing shows it is needed.
Developed with AI assistance, then manually reviewed and validated with synthetic regression tests, strict SwiftLint, the complete Apple Silicon test suite, real-world reproduction testing, and a dedicated latency benchmark. I will remain responsible for review feedback and maintenance of the contribution.