Repository navigation
ci: pin workflow runners and stabilize Ibis error test - #33
Merged
fvaleye merged 2 commits intoNov 2, 2026
Merged
Conversation
albert20260301
marked this pull request as draft
November 1, 2026 07:03
albert20260301
marked this pull request as ready for review
November 2, 2026 06:27
Contributor
Author
|
@fvaleye, please review the runner/action pins and the focused Ibis test correction. Combined CI is green across Python 3.9–3.14, lint/types and title validation (run). The cast lets the existing integration test reach the remote error instead of rejecting an unknown quoted-NULL schema locally; production type guards are unchanged. The separate #34 attempt also confirmed Ubuntu 26.04 cannot provision Python 3.9, so the existing Ubuntu 24.04 pin is needed for the supported matrix. If there is no response by November 5, I’ll leave this PR open and wait; no merge or repeat ping. After this merges, #34 can be retired as redundant. |
fvaleye
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-24.04for Linux jobs instead of the movingubuntu-latestimage.Verification
CI diagnosis and correction
The initial pinned-runner CI failed one Python 3.11 test (42 passed / 1 failed); the other five matrix jobs were cancelled. An untyped error expression was described as quoted
"NULL", rejected by Ibis before remote execution. This PR now includes the focused test correction from #34: cast the always-failing expression to BIGINT, retaining discovery and remote-error assertions without changing production type guards.The unpinned main workflow separately fails setup-python on Ubuntu 26.04 for Python 3.9. Keeping the test correction with the already-proposed Ubuntu 24.04/action pins allows the full supported matrix to run. New CI from the substantive test commit must pass before this draft is marked ready. No workflow reruns or artificial trigger commits.