Skip to content

feat(query): support bind parameters - #31

Merged
leonkenneth merged 1 commit into
altertable-ai:mainfrom
albert20260301:feat/query-params
Oct 7, 2026
Merged

leonkenneth merged 1 commit into
altertable-ai:mainfrom
albert20260301:feat/query-params

Conversation

@albert20260301

Copy link
Copy Markdown
Contributor

Summary

  • add optional params to the public query request model
  • serialize both named ($name) and positional ($1) JSON scalar bind values
  • add API documentation, changelog coverage, and focused serialization tests

Impact analysis

  • Public API: query and its accumulated/raw variants accept bind values through their shared request model.
  • Existing calls are unchanged; params is omitted unless supplied.
  • Tests: covers named and positional serialization; Java also rejects non-scalar values.
  • Cross-SDK scope: this is the active Lakehouse SDK batch. The contract documentation is in feat(lakehouse): document query bind parameters altertable-client-specs#44; the archived Lakehouse CLI is intentionally excluded.

The live Lakehouse OpenAPI already exposes this optional field. The current v0.13.0 spec tag predates its documentation, so this PR deliberately does not advance the specs submodule until the documentation PR is merged and tagged.

Validation

  • git diff --check
  • Focused local tests where toolchains are available; repository CI remains authoritative for the full matrix.

@albert20260301

Copy link
Copy Markdown
Contributor Author

@leonkenneth could you review this?

You requested the /query parameter propagation. CI is pending; please focus on the public bind-value shape, backward compatibility, and release behavior.

@leonkenneth
leonkenneth merged commit 8d5faf3 into altertable-ai:main Oct 7, 2026
9 checks passed
@albert20260301
albert20260301 deleted the feat/query-params branch October 7, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants