[DGUK-484] Bring prod/dev dockerfiles together#43
Open
currycoder wants to merge 6 commits intomainfrom
Open
Conversation
Obsiye
reviewed
Apr 29, 2026
| && chmod 0440 /etc/sudoers.d/dev-user | ||
|
|
||
| COPY --from=python-build-stage ${APP_HOME}/.venv ${VIRTUAL_ENV} | ||
| # Requirements are installed here to ensure they will be cached. |
Contributor
There was a problem hiding this comment.
looks great :) i like the multi stage build for dev and production.
I thought the binds had repitition --mount=type=bind,source=pyproject.toml and --mount=type=bind,source=uv.lock
so thought maybe copying over those files would mean it's less duplicated and more readable.
What do you think?
COPY pyproject.toml uv.lock ./
RUN --mount=type=cache,target=/root/.cache/uv \
uv sync --no-install-project
RUN --mount=type=cache,target=/root/.cache/uv \
uv sync
RUN --mount=type=cache,target=/root/.cache/uv \
uv run playwright install --with-deps chromium
Collaborator
Author
There was a problem hiding this comment.
Good call - I've done that 👍
Obsiye
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes use of docker multi stage builds to ensure that we have a single Dockerfile for local development AND production.
The build stage for production is
python-run-production, for dev ispython-run-dev. Common steps are run inpython-build-stage