Repository navigation
fix(selenide): deduplicate attachments on nested step failures - #1505
Open
chiragbitoni wants to merge 1 commit into
Open
chiragbitoni wants to merge 1 commit into
chiragbitoni wants to merge 1 commit into
Conversation
…e-framework#1453) When Selenide logs nested steps, failure in an inner step triggers afterEvent with FAIL for both the inner step and enclosing steps. Previously, this caused duplicate screenshots and page source attachments across all nesting levels. Track captured failure throwables using a WeakHashMap-backed set and verify the exception and its cause chain before capturing attachments, preventing duplicate attachments for the same failure while preserving attachments for distinct errors.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1453
Problem
When Selenide executes nested steps (for instance, a custom high-level test step wrapping an element action or assertion), failure in an inner step triggers �fterEvent with EventStatus.FAIL for both the inner step and all enclosing steps during step commit. Previously, this caused duplicate screenshot and page source attachments to be added across every enclosing step for the exact same failure.
Solution