Add a // Add features here. marker inside the default Group - #543
Merged
mogmarsh merged 2 commits intoSep 11, 2026
Merged
Conversation
create-wordpress-project's configure.php injects its companion features into a generated plugin by replacing a `// Add features here.` marker inside main.php's Group. This template no longer carried that marker, so the injection silently no-opped and those features shipped unwired. Add the marker at the Group's two-tab indentation so injected feature lines land correctly. It also serves as a clear standalone cue for where to register features. Pairs with the alleyinteractive/create-wordpress-project change that trims features.txt to feature lines and aligns its marker string; both must land together. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fcox7a64GPmpuYAfuUPm5j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See alleyinteractive/create-wordpress-project#214 for context.
tl;dr search and replace didn't work as expected.
create-wordpress-project wires its bundled features into a generated plugin by replacing a // Add features here. marker inside src/main.php's Group (main.php L16–L19). This template doesn't carry that marker anymore, so the replace does nothing and those features ship switched off.
Fix: add it back, two tabs in at the Group's indentation.
Ships with the create-wordpress-project PR that trims features.txt and lines its marker up. They go out together.
Note: this was generated with the help of Claude Code, be suspicious of its accuracy.