Skip to content

Add a // Add features here. marker inside the default Group - #543

Merged
mogmarsh merged 2 commits into
alleyinteractive:developfrom
sboisvert:fix/feature-merge-marker
Sep 11, 2026
Merged

mogmarsh merged 2 commits into
alleyinteractive:developfrom
sboisvert:fix/feature-merge-marker

Conversation

@sboisvert

Copy link
Copy Markdown
Contributor

See alleyinteractive/create-wordpress-project#214 for context.

tl;dr search and replace didn't work as expected.

create-wordpress-project wires its bundled features into a generated plugin by replacing a // Add features here. marker inside src/main.php's Group (main.php L16–L19). This template doesn't carry that marker anymore, so the replace does nothing and those features ship switched off.

Fix: add it back, two tabs in at the Group's indentation.

Ships with the create-wordpress-project PR that trims features.txt and lines its marker up. They go out together.

Note: this was generated with the help of Claude Code, be suspicious of its accuracy.

create-wordpress-project's configure.php injects its companion features into a
generated plugin by replacing a `// Add features here.` marker inside main.php's
Group. This template no longer carried that marker, so the injection silently
no-opped and those features shipped unwired. Add the marker at the Group's
two-tab indentation so injected feature lines land correctly.

It also serves as a clear standalone cue for where to register features.

Pairs with the alleyinteractive/create-wordpress-project change that trims
features.txt to feature lines and aligns its marker string; both must land
together.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fcox7a64GPmpuYAfuUPm5j

@mogmarsh mogmarsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mogmarsh
mogmarsh merged commit 050cda1 into alleyinteractive:develop Sep 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants