feat(useAsyncEffect): support synchronous cleanup functions - #2958
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Closes #2954
💡 Background and solution
useAsyncEffectcurrently accepts promises and async generators, but callers cannot return a normal React cleanup function. The hook now detects a synchronous function result and returns it directly fromuseEffect, preserving React's standard cleanup timing on dependency changes and unmount.The asynchronous promise/generator cancellation path is unchanged.
📝 Changelog
useAsyncEffectnow supports returning a synchronous cleanup function.useAsyncEffect现在支持返回同步清理函数。☑️ Self Check before Merge
Validation
vitest run packages/hooks/src/useAsyncEffect/__tests__/index.spec.ts(4 tests)tsc --noEmit -p packages/hooks/tsconfig.jsongit diff --checkAI assistance
Codex assisted with implementation, type-checking, and tests. I reviewed the complete diff and take responsibility for the change.