Fix overlay glob scoping and make scaffolds library-CI compliant - #18
Merged
Merged
Conversation
Rules scoped to examples/**, src/diffusers/**, and tests/** missed the fork overlay clone at ramp-kit/examples/..., so the catch-the-bad demo only showed 4 of 8 findings. Strip only that overlay-clone prefix. Co-authored-by: ale93.moro <ale93.moro@gmail.com>
Templates are ruff-clean with Google-style docstrings and no leftover TEMPLATE/CHANGE_ME tokens after copy. /scaffold now registers the class in inits/dummies and invokes make style, make quality, and check_copies/ check_dummies/check_repo until they exit 0. Co-authored-by: ale93.moro <ale93.moro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The overlay catch-the-bad demo missed path-prefixed rules because the fork clone lives at
ramp-kit/examples/....rule_appliesnow also matches after stripping a leadingramp-kit/segment (real repo paths stay exact).Scheduler templates are ruff-clean, replace every
TEMPLATE/CHANGE_MEtoken on copy, and/scaffoldnow registers the class in inits/dummies then invokesmake style,make quality, andcheck_copies/check_dummies/check_repountil they exit 0.step()math staysTODO(engineer). Neverconvention_check --allon the library.Verified on the fork:
python3 ramp-kit/tools/convention_check.py ramp-kit/examples/candidate_scheduleremits TEST001, SCHED001, SCHED002, SCHED003, DEPR001, MUT001, REPRO001, DEVICE001 (8 blocking).Convention gate
Ran
make test(58 tests OK). Blocking ids still enforced: SCHED001, SCHED002, SCHED003, REPRO001, DEVICE001, DEPR001, MUT001, TEST001, TEST002.Tests run
58 tests OK.